Implement chained assignment detection with is_local_in_caller_frame approach for py3.14 compat (reverting cython SetitemMixin class) #63186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompat (pandas-dev#62070)" This reverts commit a505423.
`PyFrame_GetLocals()` returns a proxy object in CPython 3.13+. Calling `PyDict_Next()` on the resulting object will not work because it is not a dictionary. Use `PyMapping_Values()` instead.
Member
Author
Quick timing gives something around 120 ns vs 160-170ns on my laptop for C vs python. In the context of a setitem operation that itself easily takes multiple microseconds (a simple |
This was referenced Nov 24, 2025
Member
|
LGTM |
jbrockmendel
approved these changes
Nov 26, 2025
Member
|
Thanks @jorisvandenbossche |
cmp0xff
added a commit
to cmp0xff/pandas-stubs
that referenced
this pull request
Dec 1, 2025
cmp0xff
added a commit
to cmp0xff/pandas-stubs
that referenced
this pull request
Dec 1, 2025
loicdiridollou
pushed a commit
to pandas-dev/pandas-stubs
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #62070, which didn't yet work for freethreaded python, and also turned out to be problematic for downstream projects with subclassing pandas (geopandas/geopandas#3676)
Using the approach discussed in #61368, thanks to @mpage!
This is using the C implementation (will still compare with the python version). Updated to use the python implementation.The large part of the diff comes from the first commit reverting the previous change. To better see what actually changed compared to before #62070, see https://github.com/pandas-dev/pandas/pull/63186/files/32b14c7ce707734a74e3cdc5a159eda6bc3aa8c1..18cbadc2b28e2463738797d8a1a2439078b10297
Closes #61368