Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
184ad31
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Sep 19, 2025
0f088f5
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Oct 4, 2025
f8e31d4
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Oct 16, 2025
259a5e4
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Oct 16, 2025
9c95525
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Oct 29, 2025
dcf4dfc
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Oct 29, 2025
4a4d976
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 11, 2025
ba029d1
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 13, 2025
e27110a
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 13, 2025
4f2dced
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 14, 2025
c6c2fad
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 14, 2025
00ad36c
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 21, 2025
87cbc42
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
e4b91c4
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
b6f945d
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
1b571f7
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
6722152
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
3f5af74
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
9372a88
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Nov 22, 2025
2730c89
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Dec 3, 2025
b5acd0b
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Dec 13, 2025
b4f28d5
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Dec 13, 2025
fff5bc5
Revert "BUG: Fix dt64[non_nano] + offset rounding"
Aniketsy Dec 13, 2025
5c89d8c
BUG: Fix dt64[non_nano] + offset rounding
Aniketsy Dec 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions pandas/core/arrays/datetimes.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
)
from pandas.core.dtypes.missing import isna

from pandas import Timedelta
from pandas.core.arrays import datetimelike as dtl
from pandas.core.arrays._ranges import generate_regular_range
import pandas.core.common as com
Expand Down Expand Up @@ -93,7 +94,6 @@

from pandas import (
DataFrame,
Timedelta,
)
from pandas.core.arrays import PeriodArray

Expand Down Expand Up @@ -817,12 +817,34 @@ def _add_offset(self, offset: BaseOffset) -> Self:
result = type(self)._from_sequence(res_values, dtype=self.dtype)

else:
result = type(self)._simple_new(res_values, dtype=res_values.dtype)
units = [
"ns",
"us",
"ms",
"s",
]
res_unit = self.unit
if hasattr(offset, "offset"):
offset_td = Timedelta(offset.offset)
offset_unit = offset_td.unit
if self.unit in units and offset_unit in units:
idx_self = units.index(self.unit)
idx_offset = units.index(offset_unit)
res_unit = units[min(idx_self, idx_offset)]
dtype_naive = np.dtype(f"datetime64[{res_unit}]")
if res_values.dtype != dtype_naive:
res_values = res_values.astype(dtype_naive)
result = type(self)._simple_new(res_values, dtype=dtype_naive)

if offset.normalize:
result = result.normalize()
result._freq = None

if self.tz is not None:
if (
self.tz is not None
and getattr(result.dtype, "tz", None) is None
and res_unit == "ns"
):
result = result.tz_localize(self.tz)

return result
Expand Down
17 changes: 17 additions & 0 deletions pandas/tests/arrays/test_datetimes.py
Original file line number Diff line number Diff line change
Expand Up @@ -844,3 +844,20 @@ def test_factorize_sort_without_freq():
tda = dta - dta[0]
with pytest.raises(NotImplementedError, match=msg):
tda.factorize(sort=True)


def test_dt64_non_nano_offset_no_rounding():
# GH#56586
dti = pd.date_range("2016-01-01", periods=3, unit="s")
offset = pd.offsets.CustomBusinessDay(offset=pd.Timedelta("1ms"))
result = dti + offset

assert result.dtype == np.dtype("datetime64[ms]")
expected = pd.DatetimeIndex(
[
pd.Timestamp("2016-01-02 00:00:00.001"),
pd.Timestamp("2016-01-03 00:00:00.001"),
pd.Timestamp("2016-01-04 00:00:00.001"),
]
)
tm.assert_index_equal(result, expected)
Loading