Added InMotion general alarms #6
Conversation
| implementation 'com.github.PhilJay:MPAndroidChart:v3.0.0' | ||
| implementation "com.github.hotchemi:permissionsdispatcher:2.2.0" | ||
| annotationProcessor "com.github.hotchemi:permissionsdispatcher-processor:2.2.0" | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) |
There was a problem hiding this comment.
compile instruction deprecated, please update Android studio/graddle
There was a problem hiding this comment.
That was probably added automatically... or stayed there when I merged with your most current code. Will update.
| android:key="@string/alarms_enabled" | ||
| android:title="Enable Alarms" | ||
| android:summary="Allow the phone to vibrate as a warning" /> | ||
|
|
There was a problem hiding this comment.
I'm not sure that it is good idea to put inmotion-specific option to general menu. Maybe it's better to move it to inmotion_preferences, or at least make it disabled by default?
| break; | ||
| case GENERAL: | ||
| if (mp.isPlaying() == false) { | ||
| mp = MediaPlayer.create(mContext, R.raw.bicycle_bell); |
There was a problem hiding this comment.
Why bicycle_bell? I think it should be separate sound, something like inmotion sound.
There was a problem hiding this comment.
I have a //TODO to change it. Will do, use the SCV default sound for that.
| @@ -1,12 +1,15 @@ | |||
| package com.cooper.wheellog; | |||
|
|
|||
| import android.app.Activity; | |||
There was a problem hiding this comment.
Are you sure that it is needed?
import android.app.Activity;
import android.app.Application;
2 participants
I`ve created a specific alarm detection for InMotion. This wheel has some internal overload alarms that are transmitted through the bluetooth connection. My patch sifts through then and presents the user with an audible alarm if it so chooses to enable it in the preferences tab.