-
Notifications
You must be signed in to change notification settings - Fork 1
enable lldp to be aware of what switch it is managing #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
internet-diglett
wants to merge
15
commits into
main
Choose a base branch
from
omicron-issue-8999
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec96140
enable lldp to be aware of what switch it is managing
internet-diglett 73a628a
add Clone to Opt
internet-diglett 3d14906
feed clippy
internet-diglett 4e43f67
make listen-addr configurable from cli
internet-diglett 1f7743e
fix args
internet-diglett da76bfd
add binaries to buildomat uploads
internet-diglett 5d0d617
use fully qualified output file path in ci job
internet-diglett bc6be3d
generate checksums in CI
internet-diglett c6e269c
fixup! generate checksums in CI
internet-diglett 81a671d
fixup! generate checksums in CI
internet-diglett d3cf8ae
fixup! generate checksums in CI
internet-diglett 1c15e82
fixup! generate checksums in CI
internet-diglett e7fc329
fill in function and regen openapi
internet-diglett e472eb4
add dendrite feature to linux binary
internet-diglett 01b7969
Linux treats 'localhost' differently than illumos
internet-diglett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we enabling
dendritefeatures on linux, when dendrite only runs onhelios?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
lldpddaemon is being added to the control plane test context in omicron#9533. The control plane test context runsdendritestub on every OS. Currently, the logic in the control plane test context assumes that the startup command for each daemon will be the same on every OS, so adding thedendritefeature to the linux binary allows us to start them both with the same command as well as get the same behavior from them on both operating systems in the testing and development environment.