commonize HTTP/HTTPS paths and use more structured errors internally #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
commented
Sep 27, 2024
This was referenced Sep 27, 2024
Merged
ahl
approved these changes
Sep 27, 2024
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
seems uncontroversially good? I don't think I have anything useful to add.
| NotOnePrivateKey, | ||
| #[error("must register an API")] | ||
| MissingApi, | ||
| #[error("only one API can be registered with a server")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this out of #1120. I wound up doing this first, even though it's less urgent, because doing the builder interface wants the more structured errors and that would have to be done in two code paths instead of one.