Skip to content
This repository was archived by the owner on Jul 22, 2021. It is now read-only.

Conversation

@ddengster
Copy link
Contributor

@ddengster ddengster commented Feb 4, 2021

pardon the sparse commit messages, i couldn't figure out a way to test github actions locally

General changes:

  • change workflow to use github actions action-ros-ci, which is used by other packages in the ROS community
  • introduces the rmf.repos file, allowing you to pull in other external repositories for testing
  • testing/coverage on a per-package basis
  • codecov bot now reports coverage

Waiting for PR fix for mixins:

todo: fixing every uncrustify issue that each package's tests will trigger when built. will wait for more PRs to go in

references:

https://github.com/ros-controls/ros2_controllers/blob/master/.github/workflows/ci.yml#L44

https://github.com/ros-tooling/action-ros-ci

https://github.com/colcon/colcon-lcov-result

@ddengster ddengster changed the title [wip] Feature/add codecov [wip] add codecoverage Feb 4, 2021
@osrf osrf deleted a comment from codecov-io Feb 5, 2021
@ddengster ddengster closed this Feb 8, 2021
@ddengster ddengster reopened this Feb 8, 2021
@ddengster ddengster force-pushed the feature/add_codecov branch from 3a70327 to ed72d58 Compare February 8, 2021 03:15
@ddengster ddengster force-pushed the feature/add_codecov branch from aa82fa3 to ab52573 Compare February 9, 2021 02:47
@ddengster ddengster changed the title [wip] add codecoverage [wip] use action-ros-ci, add codecoverage Feb 9, 2021
@ddengster ddengster mentioned this pull request Feb 9, 2021
@ddengster ddengster closed this Feb 11, 2021
@ddengster ddengster reopened this Feb 11, 2021
@osrf osrf deleted a comment from codecov-io Feb 11, 2021
@ddengster ddengster closed this Feb 11, 2021
@ddengster ddengster reopened this Feb 11, 2021
@ddengster ddengster closed this Feb 11, 2021
@ddengster ddengster reopened this Feb 11, 2021
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@28542c3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #285   +/-   ##
=========================================
  Coverage          ?   32.41%           
=========================================
  Files             ?      644           
  Lines             ?    59880           
  Branches          ?    39792           
=========================================
  Hits              ?    19412           
  Misses            ?     6648           
  Partials          ?    33820           
Flag Coverage Δ
tests 32.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28542c3...9c04e3b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants