bug-fix: nodes that start with a node outside the region but have a node in the region should be included in simple extract #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode in the region should be included "All ways that have at least one node inside the region are included" https://osmcode.org/osmium-tool/manual.html#filtering-by-tags:~:text=All%20ways%20that%20have%20at%20least%20one%20node%20inside%20the%20region%20are%20included
kucukaslan
changed the title
Contributor
Author
|
two of the failed checks seems to be related to issue described in the other one is a failure during package fetching (preparation stages). Probably a network issue, a retry can solve. none of them seems to be relevant to the PR. Please let me know, if there is anything I can or should do. |
Member
|
Good find! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual describes the
simplestrategy's output as"All ways that have at least one node inside the region are included"
However, existing code checks only the start/first node of the way and exclude the ways that have nodes inside the region.