Skip to content

Conversation

@kejadlen
Copy link
Contributor

@kejadlen kejadlen commented Dec 17, 2025

GitHub doesn't have Intel macOS runners anymore, but we also shouldn't need those builds, either. In the process of fixing this, I updated dist at the same time.

@kejadlen kejadlen requested a review from a team as a code owner December 17, 2025 22:47
@rubberduck203
Copy link
Collaborator

GitHub doesn't have Intel macOS runners anymore, but we also shouldn't need those builds, either. In the process of fixing this, I updated dist at the same time.

I didn't realize that. I looked it up and it seems that Tahoe will be the last Mac OS version to support Intel, so I'm good dropping it.

Copy link
Collaborator

@rubberduck203 rubberduck203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm curious if there was a reason we separated the dist config out from the cargo.toml.

@kejadlen
Copy link
Contributor Author

When I updated dist, it noted that configuration via Cargo.toml was legacy and offered to move it to the file, so I figured no harm switching.

It also occurs to me that we can maybe delete .github/bin/build-macos.sh since it doesn't seem to be used by anything?

@rubberduck203 rubberduck203 merged commit 243aff0 into oscope-dev:main Dec 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants