feat(osclass): allow running on heroku #2045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monaka
reviewed
Mar 21, 2017
|
|
||
| Go to [our site][installing] to get detailed information on installing Osclass. | ||
|
|
||
| ## Heroku |
There was a problem hiding this comment.
In my case, Heroku didn't detect that this repo is PHP app.
Probably because of package.json
So we'd better to set BUILDPACK_URL=https://github.com/heroku/heroku-buildpack-php.
Author
There was a problem hiding this comment.
BUILDPACK_URL is deprecated, you'll want to use heroku buildpacks:set https://github.com/heroku/heroku-buildpack-php instead.
There was a problem hiding this comment.
Ah, indeed. Anyway it's better to add such information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial config required to boot the site on heroku. Some work still needs to be done with file uploads (eg: either using the s3 plugin or writing another plugin like swift/filestack).