Relax static lifetime requirement on UsingFun #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is a backwards-incompatible change, so it will presumably require a version bump eventually. I'll leave it up to you to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of my ongoing effort to migrate wild from rayon to orx-parallel. The requirement needs to be relaxed to be able to use non-static Bumpalo allocators in
ParIterUsing:https://github.com/TechnoPorg/wild/blob/658a7fb6efcd1251ff492864a38d793f9b644db7/libwild/src/resolution.rs#L319-L322
I did not loosen the requirement for UsingClone, as I didn't know if it made sense to do so. Let me know what you think.
This PR is based on #121.