Fixed bug when using external authentication with a TNS alias (#178).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -16,6 +16,9 @@ Thin Mode Changes
 Thick Mode Changes
 ++++++++++++++++++
 
+#)  Fixed bug when using external authentication with a TNS alias
+    (`issue 178 <https://github.com/oracle/python-oracledb/issues/178>`__).
+
 Common Changes
 ++++++++++++++
 

src/oracledb/impl/base/connect_params.pyx

@@ -572,6 +572,9 @@ cdef class ConnectParamsImpl:
         if pos >= 0:
             user = credentials[:pos] or None
             password = credentials[pos + 1:] or None
+        elif connect_string is None:
+            connect_string = dsn or None
+            user = password = None
         else:
             user = credentials or None
             password = None

tests/test_1100_connection.py

@@ -138,7 +138,7 @@ def test_1104_autocommit(self):
 
     def test_1105_bad_connect_string(self):
         "1105 - connection to database with bad connect string"
-        self.assertRaisesRegex(oracledb.DatabaseError, "^DPY-4001:|ORA-12547:",
+        self.assertRaisesRegex(oracledb.DatabaseError, "^DPY-4000:|ORA-12154:",
                                oracledb.connect, test_env.get_main_user())
         self.assertRaisesRegex(oracledb.DatabaseError, "^DPY-4000:|^DPY-4001:",
                                oracledb.connect, test_env.get_main_user() + \

tests/test_4500_connect_params.py

@@ -619,5 +619,14 @@ def test_4560_dsn_with_empty_credentials(self):
             self.assertEqual(password, None)
             self.assertEqual(dsn, None)
 
+    def test_4561_dsn_with_no_credentials(self):
+        "4561 - test parsing a DSN with no credentials"
+        dsn_in = "my_alias_4561"
+        params = oracledb.ConnectParams()
+        user, password, dsn_out = params.parse_dsn_with_credentials(dsn_in)
+        self.assertEqual(user, None)
+        self.assertEqual(password, None)
+        self.assertEqual(dsn_out, dsn_in)
+
 if __name__ == "__main__":
     test_env.run_test_cases()

tests/test_env.py

@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2023, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License