Skip to content

Commit 09b1b2f

Browse files
Improve diagnosibility of unhandled message types.
1 parent ce8655f commit 09b1b2f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/oracledb/errors.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,8 @@ def _raise_from_string(exc_type: Exception, message: str) -> None:
412412
ERR_MESSAGE_HAS_NO_PAYLOAD:
413413
'message has no payload',
414414
ERR_MESSAGE_TYPE_UNKNOWN:
415-
'internal error: unknown protocol message type {message_type}',
415+
'internal error: unknown protocol message type {message_type} '
416+
'at position {position}',
416417
ERR_MISSING_BIND_VALUE:
417418
'a bind variable replacement value for placeholder ":{name}" was '
418419
'not provided',

src/oracledb/impl/thin/messages.pyx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ cdef class Message:
177177
self._process_server_side_piggyback(buf)
178178
else:
179179
errors._raise_err(errors.ERR_MESSAGE_TYPE_UNKNOWN,
180-
message_type=message_type)
180+
message_type=message_type,
181+
position=buf._pos - 1)
181182

182183
cdef int _process_return_parameters(self, ReadBuffer buf) except -1:
183184
raise NotImplementedError()

0 commit comments

Comments
 (0)