Skip to content

Conversation

@Eeshu-Yadav
Copy link
Contributor

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Use Django locale for date formatting in device page RADIUS sessions tab JS, matching Django admin and localization settings.

Fixes #662

@Eeshu-Yadav Eeshu-Yadav force-pushed the issues/662-radius_sessions_issue branch from 183d10f to aa60f50 Compare December 26, 2025 10:29
…nwisp#662

Use Django locale for date formatting in device page RADIUS sessions tab JS, matching Django admin and localization settings.

Fixes openwisp#662
@Eeshu-Yadav Eeshu-Yadav force-pushed the issues/662-radius_sessions_issue branch from aa60f50 to 830d07e Compare December 26, 2025 10:31
Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is working as expected.

The created/modified timestamp of the Device is in different format from the "Start Time" of the RADIUS session

Check the formatting of "Created" and "Modified" datetime of the Device object:
Image

Check the formatting of "Start time" field in the "RADIUS Sessions" tab:

Image

Check if something like this will solve the problem:

https://github.com/openwisp/openwisp-controller/blob/115cd9ac1b418204bdb704c02af308569e19e3fd/openwisp_controller/connection/static/connection/js/commands.js#L631-L638

@coveralls
Copy link

Coverage Status

coverage: 97.269%. remained the same
when pulling e44b632 on Eeshu-Yadav:issues/662-radius_sessions_issue
into 4053a46 on openwisp:master.

@stktyagi
Copy link
Member

stktyagi commented Dec 30, 2025

@stktyagi i am working on that as suggested by @pandafy ,

Hey @Eeshu-Yadav, sorry for any confusion. I didn’t start working on this. Since the CI failure was fixed, I just updated the branch earlier to keep it in sync and just as a check.

@Eeshu-Yadav
Copy link
Contributor Author

@stktyagi i am working on that as suggested by @pandafy ,

Hey @Eeshu-Yadav, sorry for any confusion. I didn’t start working on this. Since the CI failure was fixed, I just updated the branch earlier to keep it in sync and just as a check.

i though first , yaa ci failed previously , i thought , i will fix in next commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

[bug] RADIUS sessions tab in device page uses inconsistent date time format

4 participants