-
-
Notifications
You must be signed in to change notification settings - Fork 104
[fix] Load charts using dashboard domain #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Adityashandilya555
wants to merge
14
commits into
openwisp:master
Choose a base branch
from
Adityashandilya555:fix/chart-loading-use-dashboard-domain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c71eba6
[deps] Migrate from django-celery-email to django-post-office #477
Adityashandilya555 35d7e8e
Merge branch 'master' into issues/477-migrate-django-celery-email
Adityashandilya555 3077748
Merge branch 'master' into issues/477-migrate-django-celery-email
Adityashandilya555 68ee23e
Merge branch 'master' into issues/477-migrate-django-celery-email
Adityashandilya555 01e4e23
[deps] Migrate from django-celery-email to django-celery-email-reboot…
Adityashandilya555 6802ce1
[enhancement] Use dashboard domain for monitoring chart loading
Adityashandilya555 39b7131
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
Adityashandilya555 ef44967
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
Adityashandilya555 5ec703d
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
Adityashandilya555 e2546cb
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
Adityashandilya555 5734605
[qa] Fix RST formatting
Adityashandilya555 8cb14af
[deps] Pin sphinx<8.0.0 for docstrfmt compatibility
Adityashandilya555 ee0055e
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
nemesifier a21271c
Merge branch 'master' into fix/chart-loading-use-dashboard-domain
Adityashandilya555 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would removing
OPENWISP_MONITORING_API_BASEURLcompletely work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, removing OPENWISP_MONITORING_API_BASEURL completely should work. I checked the openwisp-monitoring source and the default value is None, which means the charts will use relative URLs and load from the current domain (the dashboard domain).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that then and simplify this. This way we don't need to define
DASHBOARD_BASEURL.Keep it simple. Please do manual testing to ensure the approach work and record a video showing the result.