Skip to content

Conversation

@Ricbet
Copy link
Member

@Ricbet Ricbet commented Dec 18, 2025

Types

  • ๐ŸŽ‰ New Features
  • ๐Ÿ› Bug Fixes
  • ๐Ÿ“š Documentation Changes
  • ๐Ÿ’„ Code Style Changes
  • ๐Ÿ’„ Style Changes
  • ๐Ÿชš Refactors
  • ๐Ÿš€ Performance Improvements
  • ๐Ÿ—๏ธ Build System
  • โฑ Tests
  • ๐Ÿงน Chores
  • Other Changes

Background or solution

ChangeLog

Summary by CodeRabbit

็‰ˆๆœฌๆ›ดๆ–ฐ

  • Chores
    • ๅ„ๅญๅŒ…ๅ‘ๅธƒ็‰ˆๆœฌ็ปŸไธ€ๅ‡็บงๅˆฐ 3.6.0ใ€‚
    • ๆ น้…็ฝฎ็‰ˆๆœฌ่ฐƒๆ•ดไธบ 2.6.0๏ผˆๅŒ…ๆ‹ฌ lerna ้…็ฝฎ๏ผ‰ใ€‚
    • OpenSumi ๆก†ๆžถๅŠ็›ธๅ…ณไพ่ต–ๅŒๆญฅๅ‡็บง่‡ณ 3.8.3-next ็ณปๅˆ—ใ€‚
    • ๆž„ๅปบ/ๅทฅๅ…ท้…็ฝฎไธญ็š„ OpenSumi ็‰ˆๆœฌๅธธ้‡ไธ€ๅนถๆ›ดๆ–ฐใ€‚

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

@Ricbet Ricbet requested a review from hacke2 December 18, 2025 05:42
@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

๐Ÿ“ Walkthrough

Walkthrough

ๅฐ†ไป“ๅบ“ไธญๅคšไธชๅŒ…็š„็‰ˆๆœฌไธŽ OpenSumi ็›ธๅ…ณๅธธ้‡็ปŸไธ€ๅ‡็บง๏ผš้กถๅฑ‚ๅ’Œ่‹ฅๅนฒๅญๅŒ…็š„ version ่‡ช 2.5.1 ๆๅ‡ไธบ 3.6.0๏ผˆ้กถๅฑ‚ๆ–ฐๅขž version: "2.6.0"๏ผ‰๏ผŒๅนถๅฐ† engines.opensumi / __OPENSUMI_VERSION__ ไปŽ 3.7.2-next-1741226843.0 ๅ‡็บง่‡ณ 3.8.3-next-1744195855.0๏ผŒๅŒๆ—ถๅŒๆญฅ่‹ฅๅนฒ @opensumi/* ไพ่ต–็‰ˆๆœฌใ€‚

Changes

Cohort / File(s) ๅ˜ๆ›ดๆ‘˜่ฆ
ๆ น็›ฎๅฝ•ๅ…ƒๆ•ฐๆฎ
package.json, lerna.json
้กถๅฑ‚ package.json ๆ–ฐๅขž/่ฎพ็ฝฎ version: "2.6.0"๏ผ›lerna.json ็š„ version ไปŽ 2.5.1 ๅ‡่‡ณ 2.6.0
ๅ„ๅŒ…็‰ˆๆœฌ็ปŸไธ€ๅ‡็บง
packages/cli/package.json, packages/code-api/package.json, packages/code-service/package.json, packages/common/package.json, packages/i18n/package.json, packages/plugin/package.json, packages/registry/package.json, packages/startup/package.json, packages/toolkit/package.json, packages/sumi-core/package.json, ...๏ผˆ่‹ฅๅนฒ packages/*/package.json๏ผ‰
ๅคšไธชๅŒ…็š„ version ไปŽ 2.5.1 ๅ‡่‡ณ 3.6.0๏ผˆpackages/cli ไธบ 3.6.0๏ผ‰
OpenSumi ๅผ•ๆ“ŽไธŽๅธธ้‡ๅ‡็บง
package.json, packages/cli/package.json, packages/toolkit/define.json
ๅฐ† engines.opensumi ไธŽ __OPENSUMI_VERSION__ ไปŽ 3.7.2-next-1741226843.0 ๅ‡็บงไธบ 3.8.3-next-1744195855.0
@opensumi/ ไพ่ต–ๅŒๆญฅๅ‡็บง*
packages/cli/package.json, packages/core/package.json, packages/sumi-core/package.json, ...๏ผˆ่‹ฅๅนฒ packages ไธ‹็š„ไพ่ต–๏ผ‰
ๅฐ†ๅคšไธช @opensumi/* ไพ่ต–็‰ˆๆœฌไปŽ 3.7.2-next-1741226843.0 ๅ‡็บง่‡ณ 3.8.3-next-1744195855.0๏ผˆๆถ‰ๅŠๅคšๆ•ฐ opensumi ็ป„ไปถ๏ผ‰

Estimated code review effort

๐ŸŽฏ 3 (Moderate) | โฑ๏ธ ~20 ๅˆ†้’Ÿ

  • ้œ€้‡็‚นๆ ธๅฏน๏ผš
    • packages/core/package.json / packages/sumi-core/package.json ไธญๅคง้‡ @opensumi/* ไพ่ต–ๆ˜ฏๅฆๅ…จ้ƒจไธ€่‡ดไธ”ๆ— ้—ๆผ๏ผ›
    • ้กถๅฑ‚ package.jsonใ€packages/cli/package.json ไธŽ packages/toolkit/define.json ไธญ OpenSumi ็‰ˆๆœฌ็š„ไธ€่‡ดๆ€ง๏ผ›
    • ๅ‘ๅธƒ็‰ˆๆœฌๅทๅ˜ๆ›ดๆ˜ฏๅฆไธŽๅ‘ๅธƒ/ๆž„ๅปบ่„šๆœฌๆˆ– CI ้…็ฝฎไฟๆŒๅŒๆญฅ๏ผˆ่‹ฅๅญ˜ๅœจ็›ธๅ…ณ CI ้…็ฝฎ๏ผŒ้œ€ๅฆๅค–ๆฃ€ๆŸฅ๏ผ‰ใ€‚

Possibly related PRs

  • feat: update opensumiย #146๏ผšๅœจ็›ธๅŒๆ–‡ไปถ้›†ๅˆไธญๆ‰น้‡ๆ›ดๆ–ฐ engines ไธŽๅคšไธช @opensumi/* ไพ่ต–็‰ˆๆœฌ๏ผˆ้ซ˜ๅบฆ็›ธๅ…ณ๏ผ‰ใ€‚
  • chore(release): release v2.4.3ย #253๏ผšๅŒๆ ทๆ‰ง่กŒไบ† monorepo ไธญ็š„็‰ˆๆœฌๅทไธŽ OpenSumi ไพ่ต–็š„ๆ‰น้‡ๅ‡็บง๏ผˆ้ซ˜ๅบฆ็›ธๅ…ณ๏ผ‰ใ€‚
  • chore(release): release v2.3.3ย #225๏ผšๅฏน lerna.json ไธŽๅคšไธช package.json ่ฟ›่กŒ็‰ˆๆœฌ/ๅ‘ๅธƒ็›ธๅ…ณๆ”นๅŠจ๏ผŒๅฑžไบŽ็›ธ่ฟ‘ๅ‘ๅธƒๆต็จ‹ๅ˜ๆ›ด๏ผˆ็›ธๅ…ณ๏ผ‰ใ€‚

Pre-merge checks and finishing touches

โœ… Passed checks (3 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed The pull request title clearly and accurately describes the main change: upgrading OpenSumi dependency from 3.7.2 to 3.8.3 across multiple packages.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
โœจ Finishing touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v2.6

๐Ÿ“œ Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 7c8a33c and c947721.

๐Ÿ“’ Files selected for processing (1)
  • package.json (2 hunks)
๐Ÿšง Files skipped from review as they are similar to previous changes (1)
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


sarah.wangxj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

๐Ÿ“œ Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 962b052 and 7c8a33c.

๐Ÿ“’ Files selected for processing (1)
  • lerna.json (1 hunks)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unittest (ubuntu-latest, 18.x)
  • GitHub Check: unittest (ubuntu-latest, 18.x)

{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"version": "2.5.1"
"version": "2.6.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โš ๏ธ Potential issue | ๐Ÿ”ด Critical

๐Ÿงฉ Analysis chain

๐Ÿ Script executed:

#!/bin/bash
# Check lerna.json configuration and all package.json versions

echo "=== lerna.json content ==="
cat -n lerna.json 2>/dev/null || echo "lerna.json not found"

echo ""
echo "=== Versioning Mode Detection ==="
if grep -q '"version"\s*:\s*"independent"' lerna.json 2>/dev/null; then
  echo "โœ“ Independent mode detected (version field is 'independent')"
else
  echo "โœ“ Fixed mode detected (version field has numeric value)"
  lerna_version=$(jq -r '.version' lerna.json 2>/dev/null)
  echo "  lerna.json version: $lerna_version"
fi

echo ""
echo "=== Checking all package.json versions ==="
# Find all package.json files and extract versions
fd -t f '^package\.json$' -x sh -c '
  version=$(jq -r ".version // \"N/A\"" "$1" 2>/dev/null)
  echo "$1: $version"
' sh {} \; | sort

Repository: opensumi/codeblitz

Length of output: 875


๐Ÿ Script executed:

#!/bin/bash
# Show git diff for lerna.json to see what changed
echo "=== Git diff for lerna.json ==="
git diff HEAD~1 lerna.json 2>/dev/null || echo "Could not retrieve git diff"

echo ""
echo "=== Recent changes to package.json files (if any) ==="
git diff --name-only HEAD~1 | grep package.json | head -10 || echo "No recent package.json changes detected"

Repository: opensumi/codeblitz

Length of output: 380


ไฟฎๅค Lerna ๅ›บๅฎšๆจกๅผไธ‹็š„็‰ˆๆœฌไธไธ€่‡ด้—ฎ้ข˜

ๅœจๅ›บๅฎšๆจกๅผไธ‹๏ผŒๆ‰€ๆœ‰ๅ—ๅฝฑๅ“็š„ๅŒ…ๅบ”ไฝฟ็”จ็›ธๅŒ็š„็‰ˆๆœฌใ€‚ๅฝ“ๅ‰ lerna.json ็š„็‰ˆๆœฌ่ฎพ็ฝฎไธบ "2.6.0"๏ผŒไฝ†ๆ‰€ๆœ‰ package.json ๆ–‡ไปถ็š„็‰ˆๆœฌๅ‡ไธบ "3.6.0"ใ€‚่ฟ™้€ ๆˆไบ† 1.0.0 ็š„็‰ˆๆœฌๅๅทฎ๏ผŒไผšๅฏผ่‡ดๅ‘ๅธƒๅ’Œ็‰ˆๆœฌ็ฎก็†้—ฎ้ข˜ใ€‚

้œ€่ฆๆ›ดๆ–ฐ lerna.json ไธญ็š„็‰ˆๆœฌๅทไธบ "3.6.0" ไปฅๅŒน้…ๆ‰€ๆœ‰ๅŒ…็š„็‰ˆๆœฌใ€‚

๐Ÿค– Prompt for AI Agents
In lerna.json around line 3, the repository is using Lerna fixed mode but the
version field is "2.6.0" while all package.json files use "3.6.0"; update the
"version" value in lerna.json to "3.6.0" so the root Lerna version matches all
package versions and prevents release/versioning inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants