[multiple] Consolidate cifmw_default_dns_servers var to group_vars #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
force-pushed
the
cifmw_default_dns_server_var
branch
2 times, most recently
from
378a8ce to
39ca908
Compare
Move the definition of dns_servers used in reproducer and libvirt_manager role to common group_var definition so that it can be easily changed and managed from group_vars. Signed-off-by: Amartya Sinha <amsinha@redhat.com>
amartyasinha
force-pushed
the
cifmw_default_dns_server_var
branch
from
39ca908 to
73b3238
Compare
Contributor
Author
|
This force push was to resolve conflicts. No actual changes were made. |
amartyasinha
requested review from
Valkyrie00,
brjackma,
bshewale,
danpawlik,
evallesp and
michburk
evallesp
approved these changes
Jan 9, 2026
bshewale
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the definition of dns_servers used in reproducer and libvirt_manager role to common group_var definition so that it can be easily changed and managed from group_vars.
Jira: https://issues.redhat.com/browse/OSPRH-22665