Use develop branch for flutter_lib #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the setup script to use the develop branch specifically for the Flutter Library repository, while keeping the App and Gatekeeper repositories on the configurable $BRANCH variable.
Key Changes:
- Hardcoded the Flutter Library repository to use the
developbranch instead of the user-configurable$BRANCHvariable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
setup-dartwing-project.sh
Outdated
| clone_or_update_repo "Flutter App" "$APP_REPO" "app" "$BRANCH" | ||
| clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH" | ||
| clone_or_update_repo "Flutter Library" "$LIB_REPO" "lib" "$BRANCH" | ||
| clone_or_update_repo "Flutter Library" "$LIB_REPO" "lib" "develop" |
There was a problem hiding this comment.
Hardcoding the branch name 'develop' for the Flutter Library breaks the consistency of branch management across repositories. Consider adding a separate LIB_BRANCH variable (defaulting to 'develop') to allow flexibility while maintaining the specific requirement. This would make the setup more maintainable if the Flutter Library branch strategy changes in the future.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| local repo_url=$2 | ||
| local target_dir=$3 | ||
| local branch=${4:-$DEFAULT_BRANCH} | ||
| local branch=${4:-develop} |
There was a problem hiding this comment.
[nitpick] Hardcoding 'develop' as the default branch removes flexibility. Consider using a configuration variable (e.g., ${DEFAULT_BRANCH:-develop}) to allow overriding the default while maintaining the new behavior.
| local branch=${4:-develop} | |
| local branch=${4:-${DEFAULT_BRANCH:-develop}} |
|
|
||
| # Clone or update repositories | ||
| clone_or_update_repo "Flutter App" "$APP_REPO" "app" "$BRANCH" | ||
| clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH" |
There was a problem hiding this comment.
[nitpick] The Flutter Library now uses a different branching strategy than the App and Gatekeeper repositories. Consider adding a comment explaining why the Flutter Library uses 'develop' while others use '$BRANCH' to improve code clarity.
| clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH" | |
| clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH" | |
| # Note: The Flutter Library uses a different branching strategy and defaults to its own 'develop' branch. | |
| # This is intentional, as the library's release workflow is managed separately from the App and Gatekeeper. |
1 participant
No description provided.