Skip to content

NO-JIRA: OWNERS: add user Rolv-Apneseth #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rolv-Apneseth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NO-JIRA: OWNERS: add user Rolv-Apneseth #1882

Rolv-Apneseth wants to merge 1 commit into from

Conversation

@Rolv-Apneseth
Copy link

@Rolv-Apneseth Rolv-Apneseth commented Jan 12, 2026

No description provided.

@openshift-ci openshift-ci bot requested review from aaradhak and jschintag January 12, 2026 11:15
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

Hi @Rolv-Apneseth. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 12, 2026
@Rolv-Apneseth
Copy link
Author

Rolv-Apneseth commented Jan 12, 2026 •
edited
Loading

Seems I got ahead of myself, apologies. Being added to the OpenShift organisation might take a couple hours, but I assumed after receiving the confirmation email I was already in. Let me know if I should close this, and other PRs against OpenShift repos, and re-open once I am in the organisation.

Edit: in the organisation now

@aaradhak
Copy link
Contributor

aaradhak commented Jan 12, 2026

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 12, 2026
aaradhak
aaradhak approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@aaradhak aaradhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2026
@aaradhak
Copy link
Contributor

aaradhak commented Jan 12, 2026

/approve

jbtrystram
jbtrystram approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, jbtrystram, Rolv-Apneseth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aaradhak,jbtrystram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aaradhak
Copy link
Contributor

aaradhak commented Jan 13, 2026

@Rolv-Apneseth : In this case , we would need to add a "NO-JIRA: " prefix in the PR title, something like the below

NO-JIRA: OWNERS: add user Rolv-Apneseth

By adding that, it would satisfy the tide CI requirement.

@aaradhak
Copy link
Contributor

aaradhak commented Jan 13, 2026

/verified by @aaradhak

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@aaradhak: This PR has been marked as verified by @aaradhak.

Details

In response to this:

/verified by @aaradhak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Rolv-Apneseth Rolv-Apneseth changed the title OWNERS: add user Rolv-Apneseth NO-JIRA: OWNERS: add user Rolv-Apneseth Jan 13, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@Rolv-Apneseth: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@HuijingHei
Copy link
Contributor

HuijingHei commented Jan 14, 2026

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2026

@Rolv-Apneseth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jschintag jschintag Awaiting requested review from jschintag

2 more reviewers

@jbtrystram jbtrystram jbtrystram approved these changes

@aaradhak aaradhak aaradhak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbtrystram jbtrystram

@aaradhak aaradhak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rolv-Apneseth @aaradhak @openshift-ci-robot @HuijingHei @jbtrystram