Skip to content

USHIFT-6362: Add iso deployment for rpmostree release scenarios #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kasturinarra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

USHIFT-6362: Add iso deployment for rpmostree release scenarios #5996

kasturinarra wants to merge 1 commit into from
+24 −10

Conversation

@kasturinarra
Copy link
Contributor

@kasturinarra kasturinarra commented Dec 30, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 30, 2025 •
edited by openshift-ci bot
Loading

@kasturinarra: This pull request references USHIFT-6362 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from agullon and vanhalenar December 30, 2025 10:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2025
@kasturinarra
Copy link
Contributor Author

kasturinarra commented Dec 30, 2025

/test images

@kasturinarra kasturinarra force-pushed the USHIFT-6362 branch 3 times, most recently from 15feeca to 7b80cf0 Compare December 31, 2025 06:35
@kasturinarra
Copy link
Contributor Author

kasturinarra commented Jan 5, 2026

@agullon could you please help review this as well ? thanks !!

agullon
agullon reviewed Jan 5, 2026
View reviewed changes
agullon
agullon reviewed Jan 5, 2026
View reviewed changes
agullon
agullon reviewed Jan 5, 2026
View reviewed changes
@kasturinarra kasturinarra force-pushed the USHIFT-6362 branch 4 times, most recently from 7b1b238 to f914821 Compare January 6, 2026 07:58
ggiguash
ggiguash reviewed Jan 7, 2026
View reviewed changes
test/bin/build_images.sh Outdated
record_junit "${groupdir}" "${template}" "compose" "SKIPPED"
continue
fi
fi
Copy link
Contributor

@ggiguash ggiguash Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this block before resolving dependencies?

Copy link
Contributor

@ggiguash ggiguash Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2026
@kasturinarra kasturinarra force-pushed the USHIFT-6362 branch 2 times, most recently from 318ed0d to 688f690 Compare January 8, 2026 09:41
ggiguash
ggiguash reviewed Jan 8, 2026
View reviewed changes
test/bin/build_images.sh Outdated
echo "Loading new definition of ${blueprint}"
sudo composer-cli blueprints push "${blueprint_file}"

# Check if the image for this blueprint already exists, in
Copy link
Contributor

@ggiguash ggiguash Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Tabulation seems wrong.

/unhold

Copy link
Contributor Author

@kasturinarra kasturinarra Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, adjusted.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@agullon
Copy link
Contributor

agullon commented Jan 8, 2026

/retest

@kasturinarra kasturinarra marked this pull request as draft January 8, 2026 13:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@kasturinarra
Copy link
Contributor Author

kasturinarra commented Jan 8, 2026

/test e2e-aws-tests-release

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@kasturinarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-release d946d66 link true /test e2e-aws-tests-release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kasturinarra kasturinarra marked this pull request as ready for review January 9, 2026 08:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2026
@openshift-ci openshift-ci bot requested review from eslutsky and jerpeter1 January 9, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

@eslutsky eslutsky Awaiting requested review from eslutsky

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

2 more reviewers

@agullon agullon agullon left review comments

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasturinarra @openshift-ci-robot @agullon @ggiguash