Skip to content

JKNS-637: Remove deprecated references #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
k37y wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JKNS-637: Remove deprecated references #1899

k37y wants to merge 1 commit into from

Conversation

@k37y
Copy link
Contributor

@k37y k37y commented Mar 16, 2025 •
edited
Loading

  • Remove CentOS references
  • Remove OpenShift V3 references
  • Use UBI base image for local development Dockerfile
  • Add all oc binaries for controller
  • Add latest stable oc binary for slave
  • Add groovy script to set node property and oc tools

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2025 •
edited by openshift-ci bot
Loading

@k37y: This pull request references JKNS-637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

  • Remove CentOS references
  • Remove OpenShift V3 references
  • Use UBI base image for local development Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avinal and divyansh42 March 16, 2025 10:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k37y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2025
@prdhamdh
Copy link
Contributor

prdhamdh commented Mar 18, 2025

I could see more centos references in following files so please check and if required please update these files as well.



  • 2/contrib/s2i/run
  • BASIC_USAGE.md
  • test-e2e/tag-in-image.sh

  • 2/test/testdata/s2i/configuration/jobs/sample-app-test/config.xml

prdhamdh
prdhamdh reviewed Mar 18, 2025
View reviewed changes
2/Dockerfile.localdev
#
# This image provides a Jenkins server, primarily intended for integration with
# OpenShift v3.
# OpenShift v4.
Copy link
Contributor

@prdhamdh prdhamdh Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove/update OpenShift V3 references from all Dockerfiles.

README.md
* [quay.io/openshift/origin-jenkins-agent-base](https://quay.io/openshift/origin-jenkins-agent-base)

**NOTE:** The jenkins-agent-maven and jenkins-agent-nodejs image are no longer maintained as of version 4.11 and no longer published as of version 4.14.
**NOTE:** The jenkins-agent-maven and jenkins-agent-nodejs image are no longer maintained as of version 4.11 and no longer published as of version 4.17.
Copy link
Contributor

@prdhamdh prdhamdh Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OCP 4 hosted images are based on UBI 8 & 9 so we can add reference of UBI 9 as well at line 7-8
I think we should add generic note here, as jenkins and jenkins-agent-base community supported images are also not maintained.

2/Dockerfile.localdev
# Stage 2 : Build slave-base with go-init
##############################################
FROM quay.io/openshift/origin-cli:4.16
FROM registry.access.redhat.com/ubi9:latest
Copy link
Contributor

@prdhamdh prdhamdh Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use ose-cli-rhel9 image instead ubi ?

@k37y
JKNS-637: Remove deprecated references
adb4209 
- Remove CentOS references
- Remove OpenShift V3 references
- Use UBI base image for local development Dockerfile
- Add all oc binaries for controller
- Add latest stable oc binary for slave
- Add groovy script to set node property and oc tools

Signed-off-by: Vinu Kochukuttan <vkochuku@redhat.com>
Signed-off-by: Vinu K <kevy.vinu@gmail.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@k37y: This pull request references JKNS-637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

  • Remove CentOS references
  • Remove OpenShift V3 references
  • Use UBI base image for local development Dockerfile
  • Add all oc binaries for controller
  • Add latest stable oc binary for slave
  • Add groovy script to set node property and oc tools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@k37y
Copy link
Contributor Author

k37y commented Apr 17, 2025

/retest-required

@prdhamdh
Copy link
Contributor

prdhamdh commented May 20, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@k37y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security adb4209 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k37y
Copy link
Contributor Author

k37y commented May 28, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2025
@k37y
Copy link
Contributor Author

k37y commented Aug 28, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 27, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2025
@k37y
Copy link
Contributor Author

k37y commented Nov 27, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avinal avinal Awaiting requested review from avinal

@divyansh42 divyansh42 Awaiting requested review from divyansh42

1 more reviewer

@prdhamdh prdhamdh prdhamdh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k37y @openshift-ci-robot @prdhamdh @openshift-bot