-
Notifications
You must be signed in to change notification settings - Fork 49
OCPBUGS-70339: deploy prometheus role and binding on hypershift guest #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dobsonj: This pull request references Jira Issue OCPBUGS-70339, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job |
|
/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance |
|
@dobsonj: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f7e19380-ec06-11f0-9b06-f136acf4239c-0 |
|
@dobsonj: This pull request references Jira Issue OCPBUGS-70339, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
these all look like flakes :( |
|
The payload job passed in https://pr-payload-tests.ci.openshift.org/runs/ci/f7e19380-ec06-11f0-9b06-f136acf4239c-0 but I want to see more runs since it was failing intermittently. /payload-aggregate periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance 10 |
|
@dobsonj: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/181d0190-ec23-11f0-8f92-54eb1c46b7fe-0 |
Actually from the logs, I see azure-disk-csi-driver-operator created the role and role binding:
|
|
In contrast, the azure-disk-csi-driver-operator log from the bug report did not deploy the role and role binding. /verified by payload-job |
|
@dobsonj: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
Thanks @dobsonj for launching the payload test! There is no additional check from the QE side. |
|
/lgtm |
|
/retest-required |
|
/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder |
|
@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder |
|
@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.21 release-4.20 |
|
@dobsonj: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder |
|
@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
These jobs passed before and nothing changed since then. Need to get out of this retest-forever loop. |
|
@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/e2e-openstack-cinder-csi, ci/prow/e2e-openstack-manila-csi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dobsonj: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5c85882
into
openshift:main
|
@dobsonj: Jira Issue Verification Checks: Jira Issue OCPBUGS-70339 Jira Issue OCPBUGS-70339 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dobsonj: new pull request created: #489 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.22.0-0.nightly-2026-01-14-031657 |
https://issues.redhat.com/browse/OCPBUGS-70339
This PR updates
pkg/driver/common/generator/base_assets.goto deploy prometheus manifests on hypershift guest clusters. All manifest updates were then generated withmake update./cc @openshift/storage