Skip to content

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Jan 7, 2026

https://issues.redhat.com/browse/OCPBUGS-70339

This PR updates pkg/driver/common/generator/base_assets.go to deploy prometheus manifests on hypershift guest clusters. All manifest updates were then generated with make update.

/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Jan 7, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70339

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 7, 2026
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-70339, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70339

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2026

/payload-job

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@dobsonj: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2026

/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@dobsonj: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f7e19380-ec06-11f0-9b06-f136acf4239c-0

@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-70339, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70339

This PR updates pkg/driver/common/generator/base_assets.go to deploy prometheus manifests on hypershift guest clusters. All manifest updates were then generated with make update.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2026

these all look like flakes :(
/retest

@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2026

The payload job passed in https://pr-payload-tests.ci.openshift.org/runs/ci/f7e19380-ec06-11f0-9b06-f136acf4239c-0 but I want to see more runs since it was failing intermittently.

/payload-aggregate periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@dobsonj: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/181d0190-ec23-11f0-8f92-54eb1c46b7fe-0

@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2026

The payload job passed in https://pr-payload-tests.ci.openshift.org/runs/ci/f7e19380-ec06-11f0-9b06-f136acf4239c-0 but I want to see more runs since it was failing intermittently.

Actually from the logs, I see azure-disk-csi-driver-operator created the role and role binding:

I0107 21:01:33.164635 1 event.go:377] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-csi-drivers", Name:"azure-disk-csi-driver-operator", UID:"f021defc-96ea-48b5-9a8e-046320b642e3", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'RoleCreated' Created Role.rbac.authorization.k8s.io/azure-disk-csi-driver-prometheus -n openshift-cluster-csi-drivers because it was missing

I0107 21:01:36.800946 1 event.go:377] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-csi-drivers", Name:"azure-disk-csi-driver-operator", UID:"f021defc-96ea-48b5-9a8e-046320b642e3", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'RoleBindingCreated' Created RoleBinding.rbac.authorization.k8s.io/azure-disk-csi-driver-prometheus -n openshift-cluster-csi-drivers because it was missing

@dobsonj
Copy link
Member Author

dobsonj commented Jan 8, 2026

In contrast, the azure-disk-csi-driver-operator log from the bug report did not deploy the role and role binding.

/verified by payload-job
/override ci/prow/okd-scos-images

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 8, 2026
@openshift-ci-robot
Copy link

@dobsonj: This PR has been marked as verified by payload-job.

Details

In response to this:

In contrast, the azure-disk-csi-driver-operator log from the bug report did not deploy the role and role binding.

/verified by payload-job
/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/okd-scos-images

Details

In response to this:

In contrast, the azure-disk-csi-driver-operator log from the bug report did not deploy the role and role binding.

/verified by payload-job
/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@duanwei33
Copy link
Contributor

/retest

@duanwei33
Copy link
Contributor

Thanks @dobsonj for launching the payload test! There is no additional check from the QE side.

@jsafrane
Copy link
Contributor

jsafrane commented Jan 8, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2026
@jsafrane
Copy link
Contributor

jsafrane commented Jan 8, 2026

/retest-required

@jsafrane
Copy link
Contributor

jsafrane commented Jan 8, 2026

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila
https://issues.redhat.com/browse/OSASINFRA-4027

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila

Details

In response to this:

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila
https://issues.redhat.com/browse/OSASINFRA-4027

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e27d70e and 2 for PR HEAD 4032ed2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 33e93a6 and 1 for PR HEAD 4032ed2 in total

@dobsonj
Copy link
Member Author

dobsonj commented Jan 8, 2026

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila

Details

In response to this:

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 8, 2026

/cherry-pick release-4.21 release-4.20

@openshift-cherrypick-robot

@dobsonj: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 8, 2026

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/hypershift-e2e-openstack-aws-csi-cinder, ci/prow/hypershift-e2e-openstack-aws-csi-manila

Details

In response to this:

/override ci/prow/hypershift-e2e-openstack-aws-csi-cinder
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 8, 2026

These jobs passed before and nothing changed since then. Need to get out of this retest-forever loop.
/override ci/prow/e2e-openstack-cinder-csi
/override ci/prow/e2e-openstack-manila-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/e2e-openstack-cinder-csi, ci/prow/e2e-openstack-manila-csi

Details

In response to this:

These jobs passed before and nothing changed since then. Need to get out of this retest-forever loop.
/override ci/prow/e2e-openstack-cinder-csi
/override ci/prow/e2e-openstack-manila-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smb-win2022-operator-e2e 4032ed2 link false /test smb-win2022-operator-e2e
ci/prow/smb-win2019-operator-e2e 4032ed2 link false /test smb-win2019-operator-e2e
ci/prow/e2e-openstack 4032ed2 link false /test e2e-openstack
ci/prow/e2e-azurestack-csi 4032ed2 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5c85882 into openshift:main Jan 8, 2026
33 of 37 checks passed
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue Verification Checks: Jira Issue OCPBUGS-70339
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-70339 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70339

This PR updates pkg/driver/common/generator/base_assets.go to deploy prometheus manifests on hypershift guest clusters. All manifest updates were then generated with make update.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@dobsonj: new pull request created: #489

Details

In response to this:

/cherry-pick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-14-031657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants