OTA-209: Add CVOConfiguration controller #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the CVO aware of a new feature gate called ClusterVersionOperatorConfiguration, which was introduced in [1]. [1]: openshift/api#2044
The controller has an empty reconcile logic as of now. The logic will be implemented later. The goal of this commit is to introduce a new CVO controller, which can optionally (depending on the state of the CVOConfiguration feature gate) create a new informer. The purpose of the `Start` method is to make the creation of a ClusterVersionOperator informer optional, and to make the creation possible later in the CVO logic by restarting the operator informer factory. To decide whether to create the informer, feature gates must be known, which happens normally later in the run when all the other informer factories are already created and inaccessible to the main CVO controller. Related enhancement: [1] [1]: https://github.com/openshift/enhancements/blob/2890cccf20ebcb94fce901f7afb170ca680aa2d9/enhancements/update/cvo-log-level-api.md
HyperShift will not create the ClusterVersionOperator CRD and CR. Thus, the relevant logic does not have to be running. Later, in HyperShift, we will configure the CVO to be configured via a configuration file instead.
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@DavidHurta: This pull request references OTA-209 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
Contributor
Author
|
The PR contains the manifests as of now as well. However, the manifests will be merged in #1161. Right now the PR contains them for testing purposes. I will drop the commits once the PR merges (or I suppose that the GitHub will start to ignore the commits). |
Contributor
|
@DavidHurta: This pull request references OTA-209 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
Testing on a Default feature set:Everything as expected. No errors: Manifests are excluded, go routine is not run: DevPreviewNoUpgrade feature set:Errors are detected: Most of the errors are expected. Otherwise, the controller is running as expected. Syncs are run every |
Contributor
Author
|
/retest-required |
DavidHurta
force-pushed
the
cvo-configuration-controller
branch
from
a002d37 to
d09c388
Compare
Contributor
Author
|
/test e2e-agnostic-usc-devpreview |
Contributor
Author
|
/test e2e-agnostic-ovn |
petr-muller
reviewed
Feb 26, 2025
petr-muller
approved these changes
Mar 12, 2025
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
/hold
I'd be more comfortable if Trevor took a look but I do not want to block this
openshift-ci
bot
added
the
do-not-merge/hold
In case the resource is deleted, enqueue a sync to set default values.
DavidHurta
force-pushed
the
cvo-configuration-controller
branch
from
d09c388 to
63878c0
Compare
Contributor
Author
|
/hold |
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
Author
|
/test ? |
Contributor
|
@DavidHurta: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/test e2e-agnostic-operator-devpreview |
petr-muller
approved these changes
Mar 12, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@DavidHurta: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/label no-qe As per internal discussion, labeling as no-qe. The OTA-209 will be tested via post-merge testing. The card consists of multiple smaller PRs. There is nothing extra to be verified by the QE on the PR. Most of the functionalities are gated and any significant regression should be discoverable via CI. |
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: cluster-version-operator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller has an empty reconciliation logic as of now.
The logic will be implemented in a follow-up PR. The goal of this PR is to introduce a new CVO controller, which can optionally (depending on the state of the
CVOConfigurationfeature gate) create a new informer.