Optimized RestClient Tests using customized Retry Handler #6359
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatulban
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
|
Nice, big win on build time for this. Seems like the gradle build is failing though. |
Signed-off-by: eatulban <eatulban@amazon.com>
eatulban
force-pushed
the
feature/RestclientTest-retry-optimization
branch
from
2980ad1 to
6c5de89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored Office365RestClient Tests using New RetryHandler, reducing test execution time from 17 minutes to 50 seconds.
Performance Summary
Test Report Details
Old Test Report(6 Retries for tests):
New Test Report(1 Retries for tests):
How
Introduced configurable retry strategies and set
maxRetries = 1for unit tests to eliminate unnecessary exponential backoff waits.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.