Skip to content

Conversation

@simonelbaz
Copy link

Description

This PR allows the user to activate deprecated path style access to S3 storage for DLQ.

Issues Resolved

Resolves #6340

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
  • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @simonelbaz ! Are these the only configurations that you want to support the path style?

@simonelbaz
Copy link
Author

Thank you for this contribution @simonelbaz ! Are these the only configurations that you want to support the path style?

@dlvenable Thanks for approving my PR.

I would to like to know if I can propose another legacy feature: legacy_md5_checksum_calculation.
It is a patch submitted by @cwperks described in: opensearch-project/OpenSearch#18240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

path style access

2 participants