Fix link html parsing for Sept 2025 release #2943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the September release was moved to the historical releases section with the release of the October release, the HTML for its link was in a new and unexpected format: <p>September<a href="/sites/default/files/2025-11/BNF%20Snomed%20Mapping%20data%2020251120.zip"> 2025 (ZIP file: 18.77MB)</a></p> <p><a href="/sites/default/files/2025-10/BNF%20Snomed%20Mapping%20data%2020251017.zip">August 2025 (ZIP file: 18.2MB)</a></p> The previous code assumed that if the link text didn't fit the "month YYYY" pattern then only the month part of the "valid from" date was part of the link text and the year part was in the following element. This was the only form of malformed historical release link we'd seen, but this fails with this new case since the missing date part is in the preceding element (and there is no following element). This commit accounts for both these types of malformed link, with an accompanying test.
Jongmassey
force-pushed
the
Jongmassey/fix-bnf-dmd-mapping-scraper
branch
from
73e4a2a to
b67c424
Compare
Contributor
Author
|
(additional line added to test fixture uses September 2023 rather than 2025 as not to break the existing "latest release" test logic) |
Contributor
Author
|
If you're wondering why this didn't affect the OpenPrescribing code that this was based on, the error is in the "valid from" date parsing, which OP doesn't do but OpenCodelists requires. |
lucyb
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the September release was moved to the historical releases section with the release of the October release,
the HTML for its link was in a new and unexpected format:
vs
The previous code assumed that if the link text didn't fit the "month YYYY" pattern then only the month part of the "valid from" date was part of the link text and the year part was in the following element. This was the only form of malformed historical release link we'd seen, but this fails with this new case since the missing date part is in the preceding element (and there is no following element).
This commit accounts for both these types of malformed link, with an accompanying test.
Fixes #2942