Updated Docker build files so they are working again #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/install vim in container
Contributor
Author
|
Any comment on this? Do you need more information? |
Contributor
@klauerm It would be better to stay on the default OpenJDK docker image for Java 17, since these are the images most commonly used. |
…\n- Switch base images to eclipse-temurin:17 for best practice\n- Remove version pinning for vim/tzdata to avoid apt errors\n- Update README to show -t usage and new image names\n- Prevent dangling images by tagging in build commands
Contributor
Author
|
OpenJDK docker image is deprecated: https://hub.docker.com/_/openjdk . One of the alternative was sapmachine. GitHub Copilot suggested using eclipse-temurin. So I use this now. @merlimat is this ok for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the benchmark tests for testing K8s Kafka clusters within our SAP landscapes. In the docker folder there where build files, that where not working for us. Therefore, I've adapted them to our needs but I think the changes are company independent. So sapmachine is an open source Java distribution and a good replacement for the outdated openjdk.
Please consider merging this PR.