Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Dec 5, 2025

Backport of JDK-8340321 from JDK17, that disables SHA-1 in TLS/DTLS 1.2 handshake signatures to comply with the Oracle JRE Cryptographic Roadmap.

Backport is not clean, as there many differences in java.security from 17 to 11.

Tested with tier1 tests on Linux and with run-test-jdk_security, that includes the new three new tests:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jdk_security                        1368  1368     0     0   
==============================
TEST SUCCESS

NOTE: This PR is on top of prerrequisite #3130 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340321 needs maintainer approval
  • Change requires CSR request JDK-8353566 to be approved

Integration blocker

 ⚠️ Dependency #3130 must be integrated first

Issues

  • JDK-8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (Enhancement - P2)
  • JDK-8353566: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3131/head:pull/3131
$ git checkout pull/3131

Update a local copy of the PR:
$ git checkout pull/3131
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3131

View PR using the GUI difftool:
$ git pr show -t 3131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3131.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2025

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into pr/3130 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 86765246d95c9e9586540c5f865ba093dff92ffe 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 5, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant