8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark

[mmm-choi]

Hi!
Backporting JDK-8324861. Manually resolved but it is a simple addition. Tested GHA, tier1 and focused test/jdk/java/lang/invoke/ tests.

Low risk, simple change of logging code.
Impact: Prevents memory leaks in diagnostic/debug scenarios

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324861 needs maintainer approval

Issue

• JDK-8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark (Bug - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3116/head:pull/3116
$ git checkout pull/3116

Update a local copy of the PR:
$ git checkout pull/3116
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3116

View PR using the GUI difftool:
$ git pr show -t 3116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3116.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mmm-choi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 705236b: 8364660: ClassVerifier::ends_in_athrow() should be removed
• 797aa64: 8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu
• 716be58: 8366221: [11u] TestPromotionFromSurvivorToTenuredAfterMinorGC.java javac build fails
• ... and 19 more: https://git.openjdk.org/jdk11u-dev/compare/c40bce3c5f56204ca23efbc072526e2bd3581d36...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mmm-choi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (21cf6d1f)

[mmm-choi]

/approval request It is a very simple fix. Low risk, simple change of logging code.

[openjdk]

@mmm-choi
8324861: The approval request has been created successfully.

[bridgekeeper]

@mmm-choi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

I wouldn't call this a clean backport - the context is significantly different from 17u - but I have verified that the changes are made in equivalent places in 11u.