fix cmake 3.5 issue #277
Open
fix cmake 3.5 issue #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu 20.04 no longer supported disable VP9 build for now as the Action workflow failed in building the library correctly
Contributor
Author
|
All checks have passed. Can this be merged please? |
Contributor
|
Hi @domibel, hi @Sunderlandkyl , can we have something like this to make the code compilable under different system with older Cmake version? |
Contributor
Author
|
CMakeLists.txt is already set to So it should be safe to bump the version slightly up to at least 3.5 in all CMakeLists.txt files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should help with the transition to CMake 4.0 #275