BUG: Call shutdown when closing socket on Windows #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@leochan2009 This change has no effect on Linux/macOS, so the failing GitHub action seems to be unrelated. |
Before closing a socket, the application should call shutdown to ensure that all data is sent and received on the closed socket. If closesocket is called without calling shutdown, any data that has not been sent may be lost. https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-closesocket
Sunderlandkyl
force-pushed
the
shutdown_socket_win
branch
from
cc001ec to
5b35488
Compare
Contributor
|
indeed. the change is only windows related. there must be some issue with Github Action. |
Contributor
Author
|
Any comments, or can it be integrated as-is? |
Contributor
|
let me test the commit with the appveyor for windows environment. will update you shortly |
Contributor
|
|
Contributor
Author
|
Thanks @leochan2009! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before closing a socket, the application should call shutdown to ensure that all data is sent and received on the closed socket. If closesocket is called without calling shutdown, any data that has not been sent may be lost.
https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-closesocket