-
Notifications
You must be signed in to change notification settings - Fork 9
fix: send the correct course_mode in the enrollment request #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @MaferMazu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@shivamtrivedi01 If you want to try out to know if this fixes your problem, you can use the zip version of the plugin: openedx-commerce.zip |
|
The fix is working fine! Thank you! |
e743560 to
73be253
Compare
73be253 to
098ce45
Compare
|
@felipemontoya @feanil, can you help me with a review? |
Description
This PR modifies the value of the
course_modesto fixed #120 (the main goal with this change is that the no-id-profesional has the correct value in the openedx enrollment request)Testing instructions
Stage
Data:
URL: https://bustreading.s2-tastewp.com/wp-admin
Username: mafermazuedunext
Password: Wzf_Jtk9fKM
Create an enrollment request in https://bustreading.s2-tastewp.com/wp-admin/edit.php?post_type=openedx_enrollment using no ID professional, it should be possible.
course-v1:OpenedX+C1+2025aspects_user_X@test.com(X being a number between 1 and 30)That sandbox is connected with a Sumac Open edX sandbox (but the course mode IDs didn't change between Sumac and main).
Your own installation
If you want to try it in your own installation:
openedx-commerce.zip
Checklist for Merge