Skip to content

Conversation

@MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Oct 16, 2025

Description

This PR modifies the value of the course_modes to fixed #120 (the main goal with this change is that the no-id-profesional has the correct value in the openedx enrollment request)

Testing instructions

Stage

Data:
URL: https://bustreading.s2-tastewp.com/wp-admin
Username: mafermazuedunext
Password: Wzf_Jtk9fKM

Create an enrollment request in https://bustreading.s2-tastewp.com/wp-admin/edit.php?post_type=openedx_enrollment using no ID professional, it should be possible.

  • You can use the course_id: course-v1:OpenedX+C1+2025
  • You can use: aspects_user_X@test.com (X being a number between 1 and 30)
  • The mode we want to test is the no ID professional, but you can also test with others.

That sandbox is connected with a Sumac Open edX sandbox (but the course mode IDs didn't change between Sumac and main).

Your own installation

If you want to try it in your own installation:
openedx-commerce.zip

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation (N/A)
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @mafermazu.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@MaferMazu
Copy link
Contributor Author

MaferMazu commented Oct 17, 2025

@shivamtrivedi01 If you want to try out to know if this fixes your problem, you can use the zip version of the plugin: openedx-commerce.zip

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 22, 2025
@shivamtrivedi01
Copy link

The fix is working fine! Thank you!

@MaferMazu MaferMazu force-pushed the mfmz/fix-course-modes branch from e743560 to 73be253 Compare December 12, 2025 16:09
@MaferMazu MaferMazu force-pushed the mfmz/fix-course-modes branch from 73be253 to 098ce45 Compare December 12, 2025 16:19
@MaferMazu
Copy link
Contributor Author

@felipemontoya @feanil, can you help me with a review?

@MaferMazu MaferMazu self-assigned this Dec 12, 2025
@MaferMazu MaferMazu merged commit 0f8c83c into openedx:main Dec 12, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

["BUG"] The course enrollment API fails after purchasing the course with no-id-professional course mode.

4 participants