Skip to content

Conversation

@MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Mar 5, 2025

Description

Adds "parent" property to avoid dynamic property creation.

This solves #106

Details

We were assigning a value to a property called "parent"


but it wasn't defined before.

In this PR, I only define a property called "parent" to avoid the dynamic property creation.

And also update the tested up version in the docs.

Testing instructions

Live link: https://openecommtest.s6-tastewp.com/wp-admin/
I already uploaded the plugin with this version.

Credentials admin

P^C)W)DOrPa&^KYsOvY8x2P3

Or you can use this branch to run make release, and compress the openedx-commerce folder as a ZIP file. Use that as a plugin to upload to your WordPress environment, and you can also upload to the test live site.

Everything should work as expected.

Additional information

Before the PR
image

https://github.com/openedx/openedx-wordpress-ecommerce/actions/runs/12168160490/job/34157245826?pr=104

After the PR
image

https://github.com/openedx/openedx-wordpress-ecommerce/actions/runs/13681127038/job/38253515240?pr=109

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation (NA)
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 5, 2025

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @mafermazu.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 5, 2025
@MaferMazu MaferMazu force-pushed the mfmz/fix-dynamic-property-warning branch from d948c92 to 817caab Compare March 5, 2025 19:25
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 6, 2025
@MaferMazu MaferMazu force-pushed the mfmz/fix-dynamic-property-warning branch from 817caab to fda7b16 Compare July 24, 2025 19:50
@MaferMazu MaferMazu marked this pull request as ready for review August 4, 2025 21:23
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to fix this in #111. So I'll merge here

@felipemontoya felipemontoya merged commit f7bd147 into openedx:main Aug 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 4, 2025
@MaferMazu MaferMazu linked an issue Aug 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

["BUG"] Creation of dynamic property

3 participants