-
Notifications
You must be signed in to change notification settings - Fork 17
Add Pg18+ support #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Pg18+ support #422
Conversation
|
Thanks for the pull request, @AntonOfTheWoods! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Signed-off-by: Anton Melser <anton.melser@outlook.com>
Also refactor common calls for DRY and simplifying any later standard collation updates Signed-off-by: Anton Melser <anton.melser@outlook.com>
Signed-off-by: Anton Melser <anton.melser@outlook.com>
cb4a48b to
f1fd6d6
Compare
Draft PR exploring support for postgres 18+.
This should be strictly identical for mysql/sqlite.
There is a "nasty hack" that simply discards
db_indexparameters passed to case insensitive columns for postgres to maintain compatibility. It appears that significant code changes would be required for selecting field types based onif connection.vendor == "postgres". Given postgres' closest option that allows forlikes (>=pg14, rather than the current types which require >=pg18) and indexes is the extensioncitext, andcitexthas been deprecated in postgres and the specialised Django class (CIText) has been removed, it seems like immediately introducing technical debt.For the two columns I could find in
openedx-learningoredx-platformthat had case-insensitive indexes -oel_collections.Collectionandoel_tagging.Taxonomy- the first is just deleted straight after in a subsequent migration and I couldn't find anywhere where the index might actually add any value for the second. My confidence level is very low on that though.I couldn't find any mentions of
MultiCollationCharField/MultiCollationTextFieldoutside of these two projects on all of public Github. Obviously that doesn't mean people aren't using it but it's promising.Would fix #422