refactor: hoist annotations for common settings with differing values

[wgu-taylor-payne]

Description

Hoist annotations for annotated settings with a type definition of the setting. There turned out to be four such settings that had differing values between the CMS and LMS common.py modules:

• ENABLE_DISCUSSION_HOME_PANEL
• ENABLE_MAX_FAILED_LOGIN_ATTEMPTS
• MAINTENANCE_BANNER_TEXT
• STUDIO_NAME

(EVENT_BUS_PRODUCER_CONFIG is another but the annotation will be brought up to the common module in #37746).

Supporting information

Closes #37281.

Testing instructions

In addition to mypy and unit tests, I ran make docs and verified the settings rendered correctly in docs/_build/html/references/settings.html and docs/_build/html/references/featuretoggles.html.

Deadline

None

Other information

ADR 0022 - Simplify Django Settings

[openedx-webhooks]

Thanks for the pull request, @wgu-taylor-payne!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.