-
Notifications
You must be signed in to change notification settings - Fork 4.2k
docs: instructor ORA api spec #37775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: instructor ORA api spec #37775
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| @@ -0,0 +1,81 @@ | |||
| # Instructor Dashboard – Open Response Assessment (ORA) API Specification | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are using Markdown instead of reStructuredText. Could you update to reStructuredText?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I've changed the format. Thanks Taylor.
|
|
||
| Once implemented, the live schema exposed at `/api-docs/` is treated as the source of truth for endpoints, schemas, authentication, parameters, and error formats. | ||
|
|
||
| After implementation, the OpenAPI specification will be updated to match the live schema and included in `/api-docs/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was decided on the grading api spec, is that we would remove the OpenAPI spec from the docs. So, I think we should go that direction here as well. I think these are great to get the work underway, but once implemented could cause some confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the text for clarity. Thanks
| - Counts by assessment type (training, peer, self, waiting, staff) | ||
| - Number of final grades received | ||
|
|
||
| **Detail endpoint** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In typical Django terminology I associate this endpoint as a list endpoint, whereas a detail endpoint is usually for one specific resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to a list endpoint. Thanks
93a8d4e to
5ead131
Compare
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally makes sense, I had a suggestion for some more context to add for future reference since edx-ora2 is technically meant to be a library.
| consumption, including consistent URL patterns, centralized permission handling, | ||
| and standardized API documentation. | ||
|
|
||
| To support the migration, a new versioned ORA API is required that follows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense. The only concern I have is that edx-ora2 is currently a separate library, but it looks like at some point someone built coupled APIs into the current instructor dash for its data. It's unlikely that we would not install edx-ora2 into the platform, but it's still not a great pattern. As you build out the new APIs, be mindful to continue to use the OraAggregateData interface.
As for this PR, it would be good to mention some of the above and be clear that it's a known issue but we're not gonna fix it as a part of this improvement. In the future, we could consider moving the rest-endpoints to the edx-ora2 library and plug-them into the instructor dash but that work won't be a part of this change.
Description
Resolves:
This PR introduces architectural decision records (ADRs) and an OpenAPI specification for the modernized Instructor Dashboard v2 API, specifically for the Open Response Assessment (ORA) section.
These documentation artifacts define the design rationale, RESTful endpoint structure, and technical contracts that will guide the v2 ORA API implementation as part of the Instructor Dashboard MFE migration.
Changes
ADR for Open Response Assessment API (
0003-ora-api-spec.rst)Defines the proposed RESTful endpoints and key architectural decisions.
OpenAPI specification for ORA endpoints (
instructor-v2-ora-api-spec.yaml)Documents the proposed v2 ORA endpoints, request/response schemas, authentication, and error formats.