This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Replace pkg_resources with importlib.resources #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irtazaakram
commented
Jan 7, 2025
irtazaakram
commented
- resolves Move on from deprecated pkg_resources api #27
- resolves Drop Python 3.8 & Add Support for Python 3.12 #29
farhan
suggested changes
Jan 13, 2025
farhan
approved these changes
Jan 13, 2025
feanil
reviewed
Jan 15, 2025
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
We should continue to support 3.11 and 3.12, we're only dropping support for 3.8
feanil
approved these changes
Jan 17, 2025
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
The requirements needed to be built with python 3.11 FYI, but I've gone ahead an done that so this is good to merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.