fix: PHP 8.2 compatibility – API cleanup #1644
Open
+64
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilpig
reviewed
Dec 31, 2025
api/v1/deleteRoutes.php
Outdated
| $r['error']=true; | ||
| $r['errorcode']=404; | ||
| return $response->withJson($r, $r['errorcode']); | ||
| } |
Collaborator
There was a problem hiding this comment.
I understand you trying to be helpful, but this little snippet, like some of the others you've added, shortcut the process and cause this function to completely skip the code that would have otherwise run on line 105.
Removed error handling for missing last port in deleteRoutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve compatibility with PHP 8.2 at the API level by fixing warnings and edge cases introduced by stricter type handling.