-
Notifications
You must be signed in to change notification settings - Fork 281
Sync Feature-php8.2_compat branch with master #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anonymoususer72041
wants to merge
17
commits into
opencats:Feature-php8.2_compat
Choose a base branch
from
anonymoususer72041:php8.2-sync
base: Feature-php8.2_compat
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync Feature-php8.2_compat branch with master #690
anonymoususer72041
wants to merge
17
commits into
opencats:Feature-php8.2_compat
from
anonymoususer72041:php8.2-sync
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* kill anything on port 80 * Update .travis.yml fix typo
attachments module will require authentication
…pencats#653) 1. Add missing asterisks to the "First Name" and "Last Name" fields 2. Add a check for the "Owner" field. This field is marked with an asterisk, which means it is required. Also, the same check already exists in the joborders validator.
…pencats#652) Default company name is saved in the database and can be changed. However, for "Add Job Order" and "Edit Job Order" forms it was hardcoded to the standard name ("Internal Posting").
…ncats#651) When using substr() or another method to reduce a string to/by 1 byte, many UTF-8 characters are lost (displayed as � ). Switching to mb_substr() fixes this.
Use history.back() method instead of currently non-functional back()
so that text files will not have a duplicate extra extension
include php 8.0, 8.2 checks
…#664) * fix session error when domain are not set, default to empty * fix typo in the Class
0b514ae to
c78e790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the current master branch into Feature-php8.2_compat to bring the PHP 8.2 compatibility branch up to date and reduce drift.
Merge conflicts were resolved conservatively with a focus on preserving existing behavior and the branch's PHP 8.2 compatibility changes.