Normalize initial database state for new installations #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR normalizes the initial database state created from
db/cats_schema.sqlby removing demo/sample tag data, resetting instance-specific seeded values to deterministic defaults, and replacingtestdomain.complaceholders with the IANA-reserved placeholder domainexample.com.In addition, it updates
modules/install/Schema.phpto migrate existing databases wheresite.last_viewed_dayisNULLor0000-00-00by backfilling a sentinel date (1000-01-01) and then enforcing a non-null default at the schema level.Motivation
Fresh installs should start from a clean, deterministic baseline without embedded demo content or leftover environment-specific values. This reduces confusion, makes the initial schema easier to reason about, and avoids noisy diffs when comparing or exporting databases.
Backfilling and normalizing
site.last_viewed_daypreventsNULL/zero-date edge cases and aligns this field with the sentinel-date approach used elsewhere in the schema while keeping existing instances consistent through an explicit migration step.Replacing
testdomain.comwith the IANA-reserved placeholder domainexample.comavoids potential confusion with real domains.