Fix candidate city search mode #679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymoususer72041
added a commit
to anonymoususer72041/OpenCATS
that referenced
this pull request
Dec 11, 2025
commit e33fbde Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Sun Dec 7 13:58:24 2025 +0100 Fix candidate city search mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the candidate city search by adding the missing
searchByCitybranch inCandidatesUI::onSearch()and addresses #654.The “City” option in the candidate search form is now correctly mapped to
SearchCandidates::byCity($query, $sortBy, $sortDirection)and the result set is post-processed to populateownerAbbrNameandresumeIDin the same way as the existing candidate search modes.A
cityWildCardStringvariable is also maintained for consistency with the other wildcard string fields.Motivation
Before this change, the candidate search page rendered the "City" option in the search dropdown without any errors, but submitting a search with that mode active caused the controller to fall through to the default case in
CandidatesUI::onSearch().As a result, the request ended with the generic "Invalid search mode." message instead of executing a proper city-based search, even though
SearchCandidates::byCity()already implements the necessary query logic.By explicitly handling the
searchByCitymode, this pull request makes the city search behave like the other supported modes and removes the invalid-mode error when users perform a city-based candidate search.