Fix #732 Ensure SpanData types are exported #731
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15fa9b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lattwood
force-pushed
the
lattwood/export_data_types
branch
from
19d5a74 to
15fa9b9
Compare
seratch
requested changes
Dec 5, 2025
Member
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Wed don't do wildcard exports in the index.ts; Can you explicitly add span data types?
seratch
changed the title
Author
|
Sure thing!
…On Fri, Dec 5, 2025 at 7:30 PM Kazuhiro Sera ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Wed don't do wildcard exports in the index.ts; Can you explicitly add span
data types?
—
Reply to this email directly, view it on GitHub
<#731 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPJNKBPHOFEI25PIQB3OPD4AIIRRAVCNFSM6AAAAACOFJYKJGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBWG4ZDQOJVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means you don't have to duplicate the types if you're implementing your own TracingExporter and want type safety.
Fixes #732