fix: no empty string matches #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case
There will be a panic when
m.Left == -1, this is the root cause of this issue.The reason why
m.Left == -1is due to theexact_month_daterule that returns an empty string for这周三(this Wednesday).But simply fixing this issue will cause another issue ↓
Fix Chinese
exact_month_dateruleThe previous regex will recognise
2下周天as2.2andnext Sunday", which should benext Sunday, since2is meaningless here.2, which is wrong.Close #47