19.0 estate stfra #1075

stfra-odoo · 2025-12-15T16:30:05Z

No description provided.

… model set

robodoo · 2025-12-15T16:30:08Z

…ta in list view and create/edit property data in form view The model was created and access rights provided but there was no interaction with the model. This is implemented through xml as its is mre convinient for complex data. There is one menu to acces the list view of the properties and a form views is displayed whend creating or editing a property. Some fields have now a default value, some are read-only, some are requiered and some cannot be copied when duplicated. The fields active and state were added for properties display in the list view by default and for it to have a different state depending on the stage respectively.

…the estate module. The views created were basic one and need some custumization to be use in a business application. List view: the following fields have been added: Title, Postcode, bedrooms, Living Area (sqm), Expected Price, Selling Price, Available From Form view: It is now composed of groups and a notebook with a page description Search view: Search has now other predifened shorcuts (Title, Postcode, expectedPrice, Bedrooms, Living Area, Facades), a predefined filter "Available" (that looks for properties with the state New or Offer received) and a Group by filter on the postcodes

…: buyer, salesperson, property type, list of tags and list of offers. Buyer Can be any individual (res.partner) Salesperson Has to be an employe (res.user) Property type New model with the name of the type (estate.property.type) Tags New model with the name of the tag (estate.property.tag) Offers New model with the buyer, price, status and property id (estate.property.offer) All those new models have list and form view but the offer model is only accessible from the porperty form (as each offer is linked to a property) A new menu setting has been added to allow the creation of new tags and types.

ushyme

Good work so far; I just have one small remark.

estate/models/estate_property.py

… area in estate property and validity and deadline in property offer). Best price is computed on the maximum price of all the offers linked to the property. Total area is computed as the sum of the lving area and garden area. Validity is the number days that have passed since the creation of the offer during wich it remains valid. Deadline is the date until wich the offer remains valid. It is computed based on validity and when changed, updates validity.

ushyme · 2025-12-19T11:56:04Z

Runbot is still red 😃

Previewsly made pull request could not pass because of the linting issues.

…s offers. The state of a property and its offer could only be changed manually which is not safe way of handling those status. Now buttons have been added : sold and cancel for the property and accept and refuse for the offers. An error pop-up is shown when trying to perfom an illegal action.

… on the models. Estate property model: - SQL constraints: check that theexpected price is stricly positive and selling price positive. - Python constraint: check that the selling price is at least 90% of the expected price when one of them is modified. Estate property offer model: - SQL constraint: check that the price is strictly positive. Estate property tag model: - SQL constraint: check that the name tag is unique. Estate property type model: - SQL constraint: check that the name type is unique.

…ttons. State are now displayed in a status bar. The buttons (Sold/cancel on properties and Accept/Refuse on offers) are now dynamic and only appeares when needed. Offers can be created and edited in place. Tags have colors. Property type can only be created and edited from the settings. Offers related to a property type can be acces from its form.

…ndart creation method of offers and the view form of an user. The new delete method with the decorator 'ondelete()' prevent the deletion of a property that is not in the state 'New' or 'Cancelled'. The new creation method prevent user from creatin an offer with a lower amount than an existing offer and change the state of the property to 'Offer recieved' when it was 'New'. The list of available properties is now displayed in a new page on the user form view.

The state of property didn't change when a new offer was made and it still had no offer. Now property state goes from 'New' to 'Offer received' when an offer is made.

…voicing module to estate module. Estate Accounting module depends on Estate and Account module to directly create an invoice the customer when a property is sold. The invoice has 3 lines: - property price - 6% fee - Addimistrative fee

ushyme

Almost there! Also, all your XML files are missing a newline at the end of the file.

ushyme · 2025-12-23T16:29:59Z

estate/models/estate_property_offer.py

+    def action_refuse(self):
+        for record in self:
+            record.status = 'refused'
+            record.property_id.property_buyer_id = None
+            record.property_id.selling_price = 0


This currently clears the property's selling price even if you are refusing a random low offer. It should only clear the property fields if the currently accepted offer is the one being refused.

Suggested change

def action_refuse(self):

for record in self:

record.status = 'refused'

record.property_id.property_buyer_id = None

record.property_id.selling_price = 0

def action_refuse(self):

for record in self:

if record.status == 'accepted':

record.property_id.selling_price = 0

record.property_id.property_buyer_id = False

record.status = 'refused'

ushyme · 2025-12-24T08:45:42Z

estate/security/ir.model.access.csv

+access_real_estate_platform,estate_property,model_estate_property,base.group_user,1,1,1,1
+access_real_estate_type,estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
+access_real_estate_tag,estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_real_estate_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1


Suggested change

access_real_estate_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1

access_real_estate_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1

missing new line at the end of the file.
this goes for most of your other non-python files as well

ushyme · 2025-12-24T08:58:09Z

estate/views/estate_property_views.xml

+        <field name="arch" type="xml">
+            <form string="Estate Property">
+                <header>
+                    <button name="action_sold" type="object" string="Sold" invisible="state in ['new', 'offer_received', 'sold', 'cancelled']" class="btn btn-primary"/>


Suggested change

<button name="action_sold" type="object" string="Sold" invisible="state in ['new', 'offer_received', 'sold', 'cancelled']" class="btn btn-primary"/>

<button name="action_sold" type="object" string="Sold" invisible="state != 'offer_accepted'" class="btn btn-primary"/>

ushyme · 2025-12-25T11:27:30Z

estate/models/estate_property.py

+            self.garden_orientation = 'north'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = ''


Use False (or None) to clear a selection field. Using an empty string '' works but isn't standard practice in Odoo.

Suggested change

self.garden_orientation = ''

self.garden_orientation = False

ushyme · 2025-12-25T11:30:19Z

estate/models/res_users.py

+
+class ResUsers(models.Model):
+    _inherit = "res.users"
+    _name = "res.users"


Suggested change

_name = "res.users"

Not needed when you are inheriting a standard Odoo model using _inherit.

ushyme · 2025-12-25T11:38:36Z

estate_account/security/ir.model.access.csv

You can delete this file. You have already defined these exact access rights in the estate module. estate_account depends on estate, so it inherits these rights automatically. You only need this file if you are adding new models or modifying rights.

ushyme · 2025-12-25T11:45:34Z

estate_account/models/estate_property.py

+        invoice_vals_list = [
+            {
+                'partner_id': self.property_buyer_id.id,
+                'move_type': 'out_invoice',
+                'invoice_line_ids': [
+                    Command.create({
+                        'name': self.name,
+                        'quantity': 1,
+                        'price_unit': self.selling_price
+                    }),
+                    Command.create({
+                        'name': "6%",
+                        'quantity': 1,
+                        'price_unit': self.selling_price * 0.06
+                    }),
+                    Command.create({
+                        'name': "Administrative fees",
+                        'quantity': 1,
+                        'price_unit': 100.0
+                    }),
+                ]
+            }
+        ]


Suggested change

invoice_vals_list = [

{

'partner_id': self.property_buyer_id.id,

'move_type': 'out_invoice',

'invoice_line_ids': [

Command.create({

'name': self.name,

'quantity': 1,

'price_unit': self.selling_price

}),

Command.create({

'name': "6%",

'quantity': 1,

'price_unit': self.selling_price * 0.06

}),

Command.create({

'name': "Administrative fees",

'quantity': 1,

'price_unit': 100.0

}),

]

}

]

invoice_vals_list = []

for record in self:

invoice_vals_list.append({

'partner_id': record.property_buyer_id.id,

'move_type': 'out_invoice',

'invoice_line_ids': [

Command.create({

'name': record.name,

'quantity': 1,

'price_unit': record.selling_price

}),

Command.create({

'name': "6%",

'quantity': 1,

'price_unit': record.selling_price * 0.06

}),

Command.create({

'name': "Administrative fees",

'quantity': 1,

'price_unit': 100.0

}),

]

})

The current implementation will raise an error if action_sold is called on multiple records. You should build invoice_vals_list for all records.

Kanban view cards are grouped by type and display the name of the property the expected price, the best price (when an offer is recieved) and the selling price (when an offer is accepted).

stfra-odoo added 2 commits December 15, 2025 16:25

[ADD] estate: Create a new module for real estate advertisment with a…

c8637b4

… model set

[FIX] estate: Fix required field needed in expected price and a typo

7dc2f6e

stfra-odoo added 2 commits December 15, 2025 17:33

[ADD] estate: Add some access rights to the db

7bcf43b

stfra-odoo force-pushed the 19.0-estate-stfra branch from f327195 to ab1280b Compare December 17, 2025 10:57

stfra-odoo added 2 commits December 17, 2025 13:41

ushyme reviewed Dec 19, 2025

View reviewed changes

estate/models/estate_property.py Outdated Show resolved Hide resolved

[LINT] estate: format file of estate module to remove linting issues.

5dafd8b

Previewsly made pull request could not pass because of the linting issues.

stfra-odoo force-pushed the 19.0-estate-stfra branch from ee173b0 to 5dafd8b Compare December 19, 2025 12:55

stfra-odoo added 7 commits December 19, 2025 17:28

[LINT] estate: add missing string to button with icon in offer view xml.

1138d95

[FIX] estate: correct the state modification of a property.

0b1c624

The state of property didn't change when a new offer was made and it still had no offer. Now property state goes from 'New' to 'Offer received' when an offer is made.

ushyme reviewed Dec 25, 2025

View reviewed changes

[IMP] estate: add a basic kanban view to estate properties.

290cf64

Kanban view cards are grouped by type and display the name of the property the expected price, the best price (when an offer is recieved) and the selling price (when an offer is accepted).

stfra-odoo force-pushed the 19.0-estate-stfra branch from 8a66f91 to 290cf64 Compare December 26, 2025 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

19.0 estate stfra #1075

19.0 estate stfra #1075

Uh oh!

stfra-odoo commented Dec 15, 2025

Uh oh!

robodoo commented Dec 15, 2025

Uh oh!

ushyme left a comment

Uh oh!

Uh oh!

ushyme commented Dec 19, 2025

Uh oh!

ushyme left a comment

Uh oh!

ushyme Dec 23, 2025

Uh oh!

ushyme Dec 24, 2025

Uh oh!

ushyme Dec 24, 2025

Uh oh!

ushyme Dec 25, 2025

Uh oh!

ushyme Dec 25, 2025

Uh oh!

ushyme Dec 25, 2025

Uh oh!

ushyme Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	access_real_estate_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
	access_real_estate_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1

	<button name="action_sold" type="object" string="Sold" invisible="state in ['new', 'offer_received', 'sold', 'cancelled']" class="btn btn-primary"/>
	<button name="action_sold" type="object" string="Sold" invisible="state != 'offer_accepted'" class="btn btn-primary"/>

19.0 estate stfra #1075

Are you sure you want to change the base?

19.0 estate stfra #1075

Uh oh!

Conversation

stfra-odoo commented Dec 15, 2025

Uh oh!

robodoo commented Dec 15, 2025

Uh oh!

ushyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ushyme commented Dec 19, 2025

Uh oh!

ushyme left a comment

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants