leker - Technical training #1063
Conversation
|
|
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
Nice work 💪🏼
Let's go with your first review 🎉
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
2 times, most recently
from
37fd581 to
cb5ea91
Compare
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
2 times, most recently
from
4b62d25 to
7b4c254
Compare
[FIX] estate: available filter bug
[FIX] estate: estate property style [FIX] estate: found use of self inside a loop on self self.price
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
from
7b4c254 to
a5f32e0
Compare
…buttons [FIX] estate: domain ative_id bug [FIX] estate: property type views prettier [FIX] estate: missing color view in tag [FIX] estate: always invisible field status removed from the offer view
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
from
a5f32e0 to
99f9309
Compare
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
Here is the last touches on this PR good luck with JS
Good job 👏🏼
| from . import estate_property_offer | ||
| from . import estate_property_tag | ||
| from . import estate_property_type | ||
| from . import base_res_users |
There was a problem hiding this comment.
for the extension inherit using _inherit we advice to use same exact file name for file_name, ClassName to ease the process of searching across all the extensions
| return True | ||
|
|
||
| @api.model_create_multi | ||
| def create(self, vals): |
There was a problem hiding this comment.
as create can be done in batch is should take vals_list instead of vals it will be a list of dicts and each dict can have different values so you need to adapt the method 🤔
| msg = "The selling price cannot be lower than 90% of the expected price" | ||
| raise ValidationError(msg) |
There was a problem hiding this comment.
I believe error with raised here in the runbot when you have the string directly. this because the Runbot expect a translation object as error msg. we should discuss this together 🫡
| msg = "The selling price cannot be lower than 90% of the expected price" | |
| raise ValidationError(msg) | |
| raise ValidationError(self,env._("The selling price cannot be lower than 90% of the expected price")) |
3 participants
No description provided.