Skip to content

Conversation

@bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Mar 20, 2025

Fixes # .

Changes proposed in this PR:

  • Add free compute system tests

@paulo-ocean
Copy link
Contributor

i think we need to rebase this @bogdanfazakas
there is a lot going on on this PR not related with adding tests :-)
IMO, you probably need to change the base to the C2D V2 branch instead

@bogdanfazakas
Copy link
Member Author

bogdanfazakas commented Mar 20, 2025

i think we need to rebase this @bogdanfazakas there is a lot going on on this PR not related with adding tests :-) IMO, you probably need to change the base to the C2D V2 branch instead

yep was just doing that at the time, also still a draft, so no need to review it yet was a mistake i've set is ready from the beginning

@bogdanfazakas bogdanfazakas changed the base branch from main to release_4.0_C2D_V2 March 20, 2025 13:36
@bogdanfazakas bogdanfazakas marked this pull request as draft March 20, 2025 13:36
@bogdanfazakas bogdanfazakas changed the base branch from release_4.0_C2D_V2 to main March 21, 2025 11:41
@bogdanfazakas bogdanfazakas changed the base branch from main to release_4.0_C2D_V2 March 21, 2025 11:42
@bogdanfazakas bogdanfazakas changed the base branch from release_4.0_C2D_V2 to main March 21, 2025 13:31
@bogdanfazakas bogdanfazakas marked this pull request as ready for review March 24, 2025 08:24
@bogdanfazakas bogdanfazakas mentioned this pull request Mar 24, 2025
@paulo-ocean
Copy link
Contributor

@bogdanfazakas get the latest changes from main. This still fails if we don't have process.env.AQUARIUS_URL
or add the legacy env vars on workflow file
tkx

@bogdanfazakas
Copy link
Member Author

his still fails if we don't have pro

sure will rebase

@paulo-ocean
Copy link
Contributor

his still fails if we don't have pro

sure will rebase

cool , thanks
maybe also worth to have a look here (i had done something for the getJobStatus)

if (!jId) {

if(hasDid) {

basically, if the the assets are not mandatory to start a compute job, than the did should not me mandatory as well

Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
I have one suggestion: Can we add to the compute tests the scenario of get compute results to have the full steps of compute jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants