-
Notifications
You must be signed in to change notification settings - Fork 6
Fix/ Add free compute system tests #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
i think we need to rebase this @bogdanfazakas |
yep was just doing that at the time, also still a draft, so no need to review it yet was a mistake i've set is ready from the beginning |
|
@bogdanfazakas get the latest changes from main. This still fails if we don't have |
sure will rebase |
cool , thanks Line 274 in 3b0cfbb
Line 855 in 3b0cfbb
basically, if the the assets are not mandatory to start a compute job, than the did should not me mandatory as well |
mariacarmina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I have one suggestion: Can we add to the compute tests the scenario of get compute results to have the full steps of compute jobs?
Fixes # .
Changes proposed in this PR: