fix: timer callback being executed after timer:stop #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27, fixes #19 , fixes #23.
How to reproduce the bug I am fixing:
ShowkeysTogglehd, this takes you to operator-pending modedin this example) fires theutils.clear_and_closecallback, the error occursThe cause: the timer of the character pressed before entering operator-pending mode (
hin my example) gets scheduled before it gets cancelled bytimer:stopwhen handling the pending operation (din my example). Because of this, the callback gets executed twice and during the second execution, thestate.winis nil, causing the error.My solution is to save
timer_id, so we can check whether the current callback is the last scheduled one.