Skip to content

Conversation

@lvitaly
Copy link

@lvitaly lvitaly commented Dec 27, 2023

Those changes were made over two years ago and have been successful in production since then. The newer Kryo version is already available there, so it is worth updating to the latest one. @npgall, what do you think?

* ArraysAsListSerializer is a part of kryo v5.0.0 default serializers
* UnmodifiableCollectionsSerializer and SynchronizedCollectionsSerializer removed due to test errors
* testEqualsAndHashCode(com.googlecode.cqengine.attribute.ReflectiveAttributeTest) is only one tests which fails after all changes
@lvitaly
Copy link
Author

lvitaly commented Dec 28, 2023

In this branch, only a few tests fail.

nix-shell -p "(maven.override { jdk = zulu17; })"
[ERROR] Failures:
[ERROR]   ReflectiveAttributeTest.testEqualsAndHashCode:76 EqualsVerifier found a problem in class com.googlecode.cqengine.attribute.ReflectiveAttribute.
-> Unsupported class file major version 65

For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
[ERROR]   PartialIndexTest.testEqualsAndHashCode_PartialDiskIndex:60 EqualsVerifier found a problem in class com.googlecode.cqengine.index.disk.PartialDiskIndex.
-> Unsupported class file major version 65

For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
[ERROR]   PartialIndexTest.testEqualsAndHashCode_PartialOffHeapIndex:69 EqualsVerifier found a problem in class com.googlecode.cqengine.index.offheap.PartialOffHeapIndex.
-> Unsupported class file major version 65

For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
[ERROR]   DiskPersistenceTest.testEqualsAndHashCode:117 EqualsVerifier found a problem in class com.googlecode.cqengine.persistence.disk.DiskPersistence.
-> Unsupported class file major version 65

For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
[ERROR]   OffHeapPersistenceTest.testEqualsAndHashCode:105 EqualsVerifier found a problem in class com.googlecode.cqengine.persistence.offheap.OffHeapPersistence.
-> Unsupported class file major version 65

For more information, go to: http://www.jqno.nl/equalsverifier/errormessages
[ERROR]   QueriesEqualsAndHashCodeTest.testQueryClass:81 EqualsVerifier found a problem in class com.googlecode.cqengine.query.simple.StringMatchesRegex.
-> Unsupported class file major version 65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant