Fix logo covering jobads #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change size of filter panel to static not scrollable change logo to christmas one
fix type of ClearFilters method
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the ListJobAd.razor component by extracting inline CSS to a separate CSS file for better maintainability, updating field naming conventions to follow .NET standards with underscore prefixes, and improving async method signatures. The key change addresses a UI bug where the logo was covering job ads by adjusting the sticky sidebar positioning.
Key Changes:
- Extracted all inline
<style>block CSS into a newListJobAd.razor.cssfile with CSS isolation - Renamed all private fields from camelCase to _camelCase following .NET conventions (e.g.,
jobAds→_jobAds,searchText→_searchText) - Changed
ClearFilters()method signature fromasync voidtoasync Taskfor proper async/await pattern - Updated sidebar sticky positioning from
top: 80pxtotop: 120pxto prevent logo overlap
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
ListJobAd.razor.css |
New CSS file containing all component styles with updated sticky positioning (top: 120px) to fix logo covering issue |
ListJobAd.razor |
Refactored to use _camelCase for private fields, removed inline styles, improved async method signature, and added null-coalescing operators for filter change handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ListJobAd component: CSS isolation and code cleanup
Description
This pull request refactors the
ListJobAd.razorcomponent to improve maintainability, fix UI layout issues, and adhere to standard C# coding conventions.Key Changes
<style>block into a separateListJobAd.razor.cssfile to leverage Blazor's CSS isolation._camelCase(e.g.,_jobAds,_searchText,_isLoading) to match .NET coding guidelines.ClearFiltersmethod signature fromasync voidtoasync Taskto ensure proper error handling and task lifecycle management.Files Changed
NoExp.Presentation/Components/Pages/JobAds/ListJobAd.razorNoExp.Presentation/Components/Pages/JobAds/ListJobAd.razor.css(New)