Skip to content

http2: optimize neverIndex lookup with SafeSet #61223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayoub-Mabrouk wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

http2: optimize neverIndex lookup with SafeSet #61223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/internal/http2/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,10 @@ function buildNgHeaderString(arrayOrMap,

const singles = new SafeSet();
const sensitiveHeaders = arrayOrMap[kSensitiveHeaders] || emptyArray;
const neverIndex = sensitiveHeaders.map((v) => v.toLowerCase());
const neverIndex = new SafeSet();
for (let i = 0; i < sensitiveHeaders.length; i++) {
neverIndex.add(sensitiveHeaders[i].toLowerCase());
}

function processHeader(key, value) {
key = key.toLowerCase();
Expand All @@ -787,7 +790,7 @@ function buildNgHeaderString(arrayOrMap,
throw new ERR_HTTP2_HEADER_SINGLE_VALUE(key);
singles.add(key);
}
const flags = neverIndex.includes(key) ?
const flags = neverIndex.has(key) ?
kNeverIndexFlag :
kNoHeaderFlags;
if (key[0] === ':') {
Expand Down