stream: readable read one buffer at a time #60441

ronag · 2025-10-27T18:44:50Z

Instead of wasting cycles concatenating buffers, just return each one by one.

nodejs-github-bot · 2025-10-27T18:44:55Z

Review requested:

@nodejs/streams

test/parallel/test-stream-readable-infinite-read.js

mcollina

code lgtm

I think some docs changes are needed

mcollina · 2026-01-02T08:05:20Z

Marked as semver-major.

lpinca · 2026-01-02T08:27:37Z

I'm -1 on this unless there is a strong reason for it. Historically, readable.read() has always returned all queued data. If this lands, I think that the easiest workaround for modules affected by the breaking change would be replacing readable.read() with readable.read(readable.readableLength).

ronag · 2026-01-02T08:48:08Z

I'm -1 on this unless there is a strong reason for it.

The performance overhead is huge. As it stand we should at least add a note to avoid this api for anything performance sensitive.

If this lands, I think that the easiest workaround for modules affected by the breaking change would be replacing readable.read() with readable.read(readable.readableLength).

Good point.

ronag · 2026-01-02T08:51:56Z

I think some docs changes are needed

What doc changes are you roughly asking for?

Instead of wasting cycles concatenating buffers, just return each one by one. Old behavior can be achieved by using `readable.read(readable.readableLength)` instead of `readable.read()`. PR: nodejs#60441

github-actions · 2026-01-02T08:58:57Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable read one buffer at a time
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20654449594

codecov · 2026-01-02T11:08:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (0457bfe) to head (87cabd8).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60441      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208736   208764      +28     
  Branches    40274    40278       +4     
==========================================
+ Hits       184810   184821      +11     
+ Misses      15944    15936       -8     
- Partials     7982     8007      +25

Files with missing lines	Coverage Δ
lib/internal/streams/readable.js	`96.27% <100.00%> (+0.01%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Do not rely on undocumented behavior, call `socket.read()` with the actual number of bytes to read. Refs: nodejs/node#60441

test/parallel/test-stream-readable-readable-one.js

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

github-actions · 2026-01-03T22:27:17Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable read one buffer at a time
   ⚠  - Update test/parallel/test-stream-readable-readable-one.js
   ⚠  - fixup
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20683777042

github-actions · 2026-01-03T22:39:34Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable read one buffer at a time
   ⚠  - Update test/parallel/test-stream-readable-readable-one.js
   ⚠  - fixup
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20683908897

mcollina

lgtm

nodejs-github-bot · 2026-01-04T16:24:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70668/

nodejs-github-bot · 2026-01-04T17:11:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70669/

mcollina

lgtm

nodejs-github-bot · 2026-01-05T08:51:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70672/

ronag requested a review from mcollina October 27, 2025 18:44

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Oct 27, 2025

MattiasBuelens reviewed Oct 31, 2025

View reviewed changes

test/parallel/test-stream-readable-infinite-read.js Outdated Show resolved Hide resolved

mcollina approved these changes Jan 2, 2026

View reviewed changes

mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 2, 2026

ronag force-pushed the read-no-copy branch 2 times, most recently from a380c35 to 0798db8 Compare January 2, 2026 08:55

ronag force-pushed the read-no-copy branch from 0798db8 to 0d7fcae Compare January 2, 2026 08:56

ronag marked this pull request as ready for review January 2, 2026 08:56

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2026

ronag force-pushed the read-no-copy branch from 0d7fcae to 8cec69c Compare January 2, 2026 08:57

ronag force-pushed the read-no-copy branch from 8cec69c to 876ff79 Compare January 2, 2026 08:58

ronag force-pushed the read-no-copy branch from 876ff79 to 01a9ec9 Compare January 2, 2026 08:58

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 2, 2026

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 2, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 2, 2026

lpinca added a commit to websockets/ws that referenced this pull request Jan 2, 2026

[fix] Ensure all remaining data is read as a single chunk

1998485

Do not rely on undocumented behavior, call `socket.read()` with the actual number of bytes to read. Refs: nodejs/node#60441

lpinca reviewed Jan 2, 2026

View reviewed changes

test/parallel/test-stream-readable-readable-one.js Outdated Show resolved Hide resolved

Update test/parallel/test-stream-readable-readable-one.js

90f2a2d

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2026

fixup

ed9afc4

ronag force-pushed the read-no-copy branch from e5302fb to ed9afc4 Compare January 3, 2026 22:20

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 3, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026

mcollina approved these changes Jan 4, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 4, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026

fixup

87cabd8

mcollina approved these changes Jan 4, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2026

Uh oh!

stream: readable read one buffer at a time #60441

Are you sure you want to change the base?

stream: readable read one buffer at a time #60441

Conversation

ronag commented Oct 27, 2025

Uh oh!

nodejs-github-bot commented Oct 27, 2025 • edited by ronag Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Jan 2, 2026

Uh oh!

lpinca commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronag commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronag commented Jan 2, 2026

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

codecov bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Jan 3, 2026

Uh oh!

github-actions bot commented Jan 3, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 4, 2026

Uh oh!

nodejs-github-bot commented Jan 4, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Oct 27, 2025 •

edited by ronag

Loading

lpinca commented Jan 2, 2026 •

edited

Loading

ronag commented Jan 2, 2026 •

edited

Loading

codecov bot commented Jan 2, 2026 •

edited

Loading